m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: 39-gary-fix-gmp-test.patch


From: Akim Demaille
Subject: Re: FYI: 39-gary-fix-gmp-test.patch
Date: Mon, 18 Aug 2003 17:26:00 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

 > Index: ChangeLog
 > from  Gary V. Vaughan  <address@hidden>

 >      * tests/Makefile.am (TESTS_ENVIRONMENT): Now we can pass make
 >      variables to the testsuite shell.  Set the value of USE_GMP so
 >      that the gmp test will run!
 >      (check-local, clean-local): Use the TESTS_ENVIRONMENT variable.

 > Index: tests/Makefile.am
 > ===================================================================
 > RCS file: /cvsroot/m4/m4/tests/Makefile.am,v
 > retrieving revision 1.34
 > diff -u -p -u -r1.34 Makefile.am
 > --- tests/Makefile.am 22 Jan 2002 16:24:26 -0000 1.34
 > +++ tests/Makefile.am 14 Aug 2003 13:17:19 -0000
 > @@ -1,5 +1,5 @@
 >  ## This file is part of GNU m4
 > -## Copyright 2000, 2001 Free Software Foundation, Inc.
 > +## Copyright 2000, 2001, 2003 Free Software Foundation, Inc.
 >  ##
 >  ## This program is free software; you can redistribute it and/or modify
 >  ## it under the terms of the GNU General Public License as published by
 > @@ -28,6 +28,8 @@ MAINTAINERCLEANFILES = Makefile.in gener
 >  OTHER_FILES = \
 >      iso8859.m4 stackovf.test
 
 > +TESTS_ENVIRONMENT = USE_GMP="$(USE_GMP)"
 > +
 >  ## ------------ ##
 >  ## package.m4.  ##
 >  ## ------------ ##
 > @@ -54,10 +56,10 @@ TESTSUITE_AT = \
 >  TESTSUITE = testsuite
 
 >  check-local: atconfig $(TESTSUITE)
 > -    $(SHELL) $(srcdir)/$(TESTSUITE)
 > +    $(TESTS_ENVIRONMENT) $(SHELL) $(srcdir)/$(TESTSUITE)
 
 >  clean-local:
 > -    $(srcdir)/testsuite --clean
 > +    $(TESTS_ENVIRONMENT) $(SHELL) $(srcdir)/$(TESTSUITE) --clean
 
 >  # Using variables so that this snippet is not too wide and can
 >  # be used as is in Texinfo @example/@end example.


This patch is wrong, since the goal of ./testsuite is to be able to be
run easily by hand.  The functionality of TESTS_ENVIRONMENT you are
looking for is in atlocal.  If GMP does not work, dig in there.

I still cannot build M4, so I can't help.  Libtool is definitely not
helping me figuring out what's wrong :(




reply via email to

[Prev in Thread] Current Thread [Next in Thread]