m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

add gmp library dependency; get dist to work...


From: Ralf Wildenhues
Subject: add gmp library dependency; get dist to work...
Date: Tue, 13 Jun 2006 18:00:00 +0200
User-agent: Mutt/1.5.11

This seems to have gotten lost during some of the restructuring,
see the first patch below.  It fixes a test failure:
| 12: gmp                                           FAILED (builtins.at:301)

(and yes, in order to be able to even get `make' to succeed, I need to
fiddle with gnulib getopt currently; __getopt_argv_const is not #defined
in my system getopt.h, but it's used unconditionally in src/getopt1.c).


FWIW, I currently get one other failure:
| 52: [Erenamesyms and Renamesyms]                  FAILED (generated.at:352)

due to a segmentation fault of m4:
| 52. generated.at:342: testing ...
| ../../m4/tests/generated.at:352: m4 -b -d input.m4
| --- /dev/null   2006-05-31 19:23:06.194058360 +0200
| +++ /tmp/build/tests/testsuite.dir/at-stderr      2006-06-13 
17:41:43.000000000 +0200
| @@ -0,0 +1 @@
| +/tmp/build/tests/m4: line 7:  6985 Segmentation fault      (core dumped) 
"/tmp/build/src/m4" --module-directory="/tmp/build/modules" ${1+"$@"} 
2>/tmp/m4-$$
| --- -   2006-06-13 17:41:43.360739000 +0200
| +++ /tmp/build/tests/testsuite.dir/at-stdout      2006-06-13 
17:41:43.000000000 +0200
| @@ -1,2 +1 @@
| 
| -
| ../../m4/tests/generated.at:352: exit code was 139, expected 0
| 52. generated.at:342: 52. Erenamesyms and Renamesyms (generated.at:342): 
FAILED (generated.at:352)

If I kill that test, do the getopt munging, and apply the other trivial
patch below, and shorten out the two(!) NEWS checks (one inserted by
Makefile.am, the other by Automake, as documented), I can get `make
dist' to succeeed -- yay!

distcheck then fails because installcheck fails these tests:
|  34: modules.at:27      Freezing modules
|  41: modules.at:135     modules: shadow
|  42: modules.at:275     modules: unload
|  43: modules.at:348     modules: importing
|  44: modules.at:406     modules: trace

with failures all similar to this one:
| +m4: input.m4: 12: cannot open module `shadow': file not found

I'll leave that for you to find out.

Cheers,
Ralf

        * Makefile.am (modules_mpeval_la_LIBADD): Readd $(LIBADD_GMP).

Index: Makefile.am
===================================================================
RCS file: /cvsroot/m4/m4/Makefile.am,v
retrieving revision 1.26
diff -u -r1.26 Makefile.am
--- Makefile.am 13 Jun 2006 01:19:09 -0000      1.26
+++ Makefile.am 13 Jun 2006 16:00:39 -0000
@@ -144,7 +144,7 @@
 pkglibexec_LTLIBRARIES        += modules/mpeval.la
 EXTRA_modules_mpeval_la_SOURCES        = modules/evalparse.c
 modules_mpeval_la_LDFLAGS      = $(module_ldflags)
-modules_mpeval_la_LIBADD       = $(module_libadd)
+modules_mpeval_la_LIBADD       = $(module_libadd) $(LIBADD_GMP)
 endif
 
 ## Disabled for now.  It is too fragile to be useful.




        * Makefile.am (EXTRA_DIST): doc/helptoman.pl is gone.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/m4/m4/Makefile.am,v
retrieving revision 1.26
diff -u -r1.26 Makefile.am
--- Makefile.am 13 Jun 2006 01:19:09 -0000      1.26
+++ Makefile.am 13 Jun 2006 15:50:24 -0000
@@ -263,8 +263,6 @@
 ## TAGS_DEPENDENCIES = $(TAGS_FILES)
 ## ETAGS_ARGS  = --language=none --regex='/@node \([^,]*\)/\1/' $(TAGS_FILES)
 
-EXTRA_DIST     += doc/helptoman.pl
-
 MAINTAINERCLEANFILES += $(dist_man_MANS)
 
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]