m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'make check' from system() under Python


From: Eric Blake
Subject: Re: 'make check' from system() under Python
Date: Mon, 05 Feb 2007 06:23:11 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 2/4/2007 9:45 PM:
> 
> I'm thinking that I'll just change the test to use SIGKILL only, since we
> have proven that SIGPIPE is risky to rely on portably.  M4 doesn't have a
> bug, so much as the testsuite.

Like so:

2007-02-05  Eric Blake  <address@hidden>

        * doc/m4.texinfo (Sysval): Avoid SIGPIPE in test as unreliable.
        Reported by Albert Chin.
        * THANKS: Update.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFxy+/84KuGfSFAYARAqxEAJ9GbHC7mxdmHQ8iJTbnuxKyALCR+ACgkpfV
hJVUwPZ/ehZ2JEV2Lh5mMQY=
=1K4a
-----END PGP SIGNATURE-----
Index: doc/m4.texinfo
===================================================================
RCS file: /sources/m4/m4/doc/m4.texinfo,v
retrieving revision 1.1.1.1.2.112
diff -u -p -r1.1.1.1.2.112 m4.texinfo
--- doc/m4.texinfo      3 Feb 2007 23:11:24 -0000       1.1.1.1.2.112
+++ doc/m4.texinfo      5 Feb 2007 13:22:18 -0000
@@ -5152,17 +5152,19 @@ signal number shifted left by eight bits
 @comment exits normally rather than letting the signal terminate it).
 @comment Also, TERM is flaky, as it can also kill the running m4 on
 @comment systems where /bin/sh does not create its own process group.
address@hidden That leaves KILL and PIPE as the two signals tested.
address@hidden And PIPE is unreliable, since people tend to run with it
address@hidden ignored, with m4 inheriting that choice.  That leaves KILL as
address@hidden the only signal we can reliably test.
 @example
 dnl This test assumes kill is a shell builtin, and that signals are
 dnl recognizable.
 ifdef(`__unix__', ,
       `errprint(` skipping: syscmd does not have unix semantics
 ')m4exit(`77')')dnl
-syscmd(`kill -13 $$')
+syscmd(`kill -9 $$')
 @result{}
 sysval
address@hidden
address@hidden
 esyscmd(`kill -9 $$')
 @result{}
 sysval

reply via email to

[Prev in Thread] Current Thread [Next in Thread]