[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make 3.81 MinGW port and testsuite working with MSYS
From: |
Eli Zaretskii |
Subject: |
Re: make 3.81 MinGW port and testsuite working with MSYS |
Date: |
Sun, 27 Feb 2005 06:58:31 +0200 |
> Date: Sun, 27 Feb 2005 01:06:37 +0000
> From: "J. Grant" <address@hidden>
> CC: Eli Zaretskii <address@hidden>, address@hidden
>
> (In my view I do not think we should not include .exe as part of the
> program output string. The other ports only display "make" or "gmake" etc.)
I'm not sure I understand: do you think we should keep the .exe or do
you think we should remove it?
As I already said, the DJGPP port was showing "make.exe" for years,
and it was never a problem. I don't think we should change it now, as
it could break something that relies on this, e.g. in sub-make's, or
the value of the $MAKE variable. I say, let's leave the .exe alone.
> if (program == 0)
> program = argv[0];
> else
> - ++program;
> + {
> + /* Increment past the initial '\', if there is another character
> after. */
> + if(program[0] == '/' || program[0] == '\\')
> + {
> + int str_len_p = strlen(program);
> + if(str_len_p > 1)
> + ++program;
> + }
> + }
Why did you need this snippet? The test for '/' or '\' was already
done above, so what case does this handle?
- Re: make 3.81 MinGW port and testsuite working with MSYS, (continued)
- Re: make 3.81 MinGW port and testsuite working with MSYS, J. Grant, 2005/02/28
- Re: make 3.81 MinGW port and testsuite working with MSYS, Paul D. Smith, 2005/02/28
- Re: make 3.81 MinGW port and testsuite working with MSYS, Paul D. Smith, 2005/02/25
- Re: make 3.81 MinGW port and testsuite working with MSYS, Eli Zaretskii, 2005/02/26
- Re: make 3.81 MinGW port and testsuite working with MSYS, Paul D. Smith, 2005/02/26
- Re: make 3.81 MinGW port and testsuite working with MSYS, Eli Zaretskii, 2005/02/26
- Re: make 3.81 MinGW port and testsuite working with MSYS, J. Grant, 2005/02/26
- Re: make 3.81 MinGW port and testsuite working with MSYS,
Eli Zaretskii <=
- Re: make 3.81 MinGW port and testsuite working with MSYS, Paul D. Smith, 2005/02/27
- Re: make 3.81 MinGW port and testsuite working with MSYS, J. Grant, 2005/02/28
- Re: make 3.81 MinGW port and testsuite working with MSYS, Alessandro Vesely, 2005/02/28
- Re: make 3.81 MinGW port and testsuite working with MSYS, Alessandro Vesely, 2005/02/26
- Re: make 3.81 MinGW port and testsuite working with MSYS, Paul D. Smith, 2005/02/26