[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ctrl-C patch (Re: Savannah W32 patches... are any OK?
From: |
Alessandro Vesely |
Subject: |
Ctrl-C patch (Re: Savannah W32 patches... are any OK? |
Date: |
Tue, 01 Mar 2005 10:54:45 +0100 |
"Paul D. Smith" wrote:
>
> >> https://savannah.gnu.org/patch/index.php?func=detailitem&item_id=3679
> >>
> >> > CTRL-C on Windows causes make to crash. This was because of the
> >> > wrong implementation of w32_kill, dereferencing a pid as a
> >> > pointer. The attached patch (targetting mingw32-make-3.80.0-3)
> >> > fixes it.
> >>
> >> This seems straightforward enough but Alessandro posted a followup
> >> that said the change given was not correct and a different solution
> >> was needed... any thoughts on this?
>
> ez> I tend to agree with Alessandro, but a specific patch he suggests
> ez> would be nice: it's hard to think about this on purely theoretical
> ez> grounds.
>
> I agree; so we're waiting for someone to provide an updated patch here.
I posted a patch doing `exit(EXIT_FAILURE)' rather than `kill (getpid(), sig)'
to terminate the running program at the end of the signal handler.
- Ctrl-C patch (Re: Savannah W32 patches... are any OK?,
Alessandro Vesely <=