make-w32
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

MinGW/MSYS testsuite results / failures


From: J. Grant
Subject: MinGW/MSYS testsuite results / failures
Date: Sat, 19 Mar 2005 01:38:07 +0000
User-agent: Mozilla/5.0 (X11; U; GNU/Linux i686; en; rv:1.5.0; hi) Gecko/20030604

Hello,

Okay, I completed a test run. Attached is a text file with some annotated
numbered tests.  Please see below for the details of which test numbers
I think are make bugs, and which are win32 shell issue.

You will need to apply these two patches to fix two remaining bugs in
the CVS code:

Okay, sigsignal.c still has #if !defined(HAVE_DECL_SYS_SIGLIST) incorrectly.
Please review 2005-03-19_signame.c_have_decl_sys_syslist.patch for
inclusion in CVS source.

Also, there is an extra problem in the CVS source which results in
"ake" being displayed instead of "make".  Please review
2005-03-19_main.c_remove_extra_inc.patch for inclusion in CVS source.

In addition attached are MSVC .sln/.vcproj files which I use and can be
included in CVS.

There is a bug in the way echo works from MSYS rxvt, to see run this:

$ ./make -fvar.mak
maketemp=\C:/msys/1.0/home/jg/beta/make.exe"
echo C:/msys/1.0/home/jg/beta/make.exe
C:/msys/1.0/home/jg/beta/make.exe

=============
#var.mak
all:
         @echo 'maketemp="$(MAKE)"'
         echo $(MAKE)
=============

This is the command like that results:
"sh C:\msys\1.0\bin\echo maketemp=\"make\""

As you can see there is an extra back-slash, which breaks some things.

The tests that fail because of this problem are:

These are the tests which I think we should try and find solutions for:

1,2,3, 5, 7, 9, 11, 12, 15, 28

extra slash in string (echo bug):

8,24,25,26,27

symlinks (unsupported, perhaps we should support?):
16,17,18,19,20

Is test (4) a problem being in a different order?

Tests which only fail because of incorrectly created base output file:
6, 13,14, 21,22,23

Kind regards
JG
Index: signame.c
===================================================================
RCS file: /cvsroot/make/make/signame.c,v
retrieving revision 1.19
diff -u -r1.19 signame.c
--- signame.c   4 Mar 2005 12:52:32 -0000       1.19
+++ signame.c   19 Mar 2005 01:20:05 -0000
@@ -27,7 +27,7 @@
    Otherwise create our own.
  */
 
-#if !defined(HAVE_DECL_SYS_SIGLIST)
+#if defined(HAVE_DECL_SYS_SIGLIST)
 
 /* Some systems do not define NSIG in <signal.h>.  */
 #ifndef        NSIG
@@ -234,7 +234,7 @@
 {
   static char buf[] = "Signal 12345678901234567890";
 
-#if !defined(HAVE_DECL_SYS_SIGLIST)
+#if defined(HAVE_DECL_SYS_SIGLIST)
   static char sig_initted = 0;
 
   if (!sig_initted)

   Running tests for GNU make on MINGW32_NT-5.0 NP850 1.0.10(0.46/3/2) i686
                             GNU Make 3.81beta3

features/export ......................................... FAILED (7/10 passed)


1)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/features/export.mk 
UNEXPORT_ALL=1' returned 0.
Comparing Output ........ DIFFERENT OUTPUT
base_file work/features/export.base.3
==============
FOO=foo BAR=bar BAZ=baz BOZ=boz BITZ=bitz BOTZ=botz
FOO= BAR= BAZ=baz BOZ=boz BITZ=bitz BOTZ=
=================

diff_file work/features/export.log.3
==============================
FOO=foo BAR=bar BAZ=baz BOZ=boz BITZ=bitz BOTZ=botz
FOO=foo BAR= BAZ=baz BOZ=boz BITZ=bitz BOTZ=
================================




2)
run_command_with_output: 'diff -c work/features/export.base.3 
work/features/export.log.3' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/features/export.mk 
EXPORT_ALL=1 UNEXPORT_ALL=1' returned 0.
Comparing Output ........ DIFFERENT OUTPUT
base_file work/features/export.base.4
===========
FOO=foo BAR=bar BAZ=baz BOZ=boz BITZ=bitz BOTZ=botz
FOO= BAR= BAZ=baz BOZ=boz BITZ=bitz BOTZ=
===========
diff_file work/features/export.log.4
===========
FOO=foo BAR=bar BAZ=baz BOZ=boz BITZ=bitz BOTZ=botz
FOO=foo BAR= BAZ=baz BOZ=boz BITZ=bitz BOTZ=
===========


3)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/features/export.mk.1' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/features/export.diff.6
=======================================
*** work/features/export.base.6 Wed Mar 16 22:05:22 2005
--- work/features/export.log.6  Wed Mar 16 22:05:22 2005
***************
*** 1,2 ****
! foo=f-ok bar=b-ok
! foo=f-ok bar=b-ok
--- 1,2 ----
! foo=f-ok bar=b-ok
! foo= bar=
=========================================
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/features/parallelism.mk.2 -j 4' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

4)
diff_file work/features/parallelism.diff.2
===============================
*** work/features/parallelism.base.2    Wed Mar 16 22:05:40 2005
--- work/features/parallelism.log.2     Wed Mar 16 22:05:40 2005
***************
*** 1,7 ****
! ONE.inc
! THREE.inc
! TWO.inc
! ONE
! THREE
! TWO
! success
--- 1,7 ----
! THREE.inc
! ONE.inc
! TWO.inc
! ONE
! TWO
! THREE
! success
===============================

5)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/features/patspecific_vars.mk' returned 512.
Error running C:/msys/1.0/local/bin/make (expected 0; got 512): 
C:/msys/1.0/local/bin/make -f work/features/patspecific_vars.mk
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/features/patspecific_vars.diff.4
======================
*** work/features/patspecific_vars.base.4       Wed Mar 16 23:36:08 2005
--- work/features/patspecific_vars.log.4        Wed Mar 16 23:36:08 2005
***************
*** 0 ****
--- 1 ----
+ make: *** [/bar] Error 1
======================


6)
features/recursion ...................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/features/recursion.mk CFLAGS=-O -w-j 2' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/features/recursion.diff
===============================
*** work/features/recursion.base        Wed Mar 16 23:36:10 2005
--- work/features/recursion.log Wed Mar 16 23:36:10 2005
***************
*** 1,13 ****
! make: Entering directory `/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make -f work/features/recursion.mk foo
! make[1]: Entering directory `/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make
! MAKELEVEL = 1
! C:/msys/1.0/local/bin/make -f work/features/recursion.mk last
! make[2]: Entering directory `/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make
! MAKELEVEL = 2
! THE END
! make[2]: Leaving directory `/home/now3d/beta/cvs/make/tests'
! make[1]: Leaving directory `/home/now3d/beta/cvs/make/tests'
! make: Leaving directory `/home/now3d/beta/cvs/make/tests'
--- 1,13 ----
! make: Entering directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make -f work/features/recursion.mk foo
! make[1]: Entering directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make
! MAKELEVEL = 1
! C:/msys/1.0/local/bin/make -f work/features/recursion.mk last
! make[2]: Entering directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make
! MAKELEVEL = 2
! THE END
! make[2]: Leaving directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
! make[1]: Leaving directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
! make: Leaving directory `C:/msys/1.0/home/now3d/beta/cvs/make/tests'
===============================

recursion.base not created correctly. Should have c:/msys/1.0/  on argument 
directory as well

! make: Entering directory `/home/now3d/beta/cvs/make/tests'
! C:/msys/1.0/local/bin/make -f work/features/recursion.mk foo

I fixed the recursion.base file by hand and the output is the same


7)
functions/abspath ....................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/abspath.mk' returned 512.
Error running C:/msys/1.0/local/bin/make (expected 0; got 512): 
C:/msys/1.0/local/bin/make -f work/functions/abspath.mk
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/abspath.diff
=================================
*** work/functions/abspath.base Wed Mar 16 23:36:22 2005
--- work/functions/abspath.log  Wed Mar 16 23:36:22 2005
***************
*** 0 ****
--- 1 ----
+ work/functions/abspath.mk:3: *** .  Stop.
=================================


8)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/eval.mk.6' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/eval.diff.7
=======================
*** work/functions/eval.base.7  Wed Mar 16 23:36:24 2005
--- work/functions/eval.log.7   Wed Mar 16 23:36:24 2005
***************
*** 1,2 ****
! hello
! world
--- 1,2 ----
! he\llo
! world
=======================


9)
functions/value ......................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/value.mk' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/value.diff
============================
*** work/functions/value.base   Wed Mar 16 23:36:26 2005
--- work/functions/value.log    Wed Mar 16 23:36:26 2005
***************
*** 1 ****
! FOO = OO FOO = foo FOO = foo FOO = foo
--- 1 ----
! FOO = 6OO FOO = foo FOO = foo FOO = foo
============================



10)
functions/wildcard ...................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/wildcard.mk print1' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/wildcard.diff
======================================
======================================

11)
Creating Difference File ...
run_command_with_output: 'diff -c work/functions/wildcard.base 
work/functions/wildcard.log' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/wildcard.mk print2' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/wildcard.diff.1
======================================
*** work/functions/wildcard.base.1      Wed Mar 16 23:36:28 2005
--- work/functions/wildcard.log.1       Wed Mar 16 23:36:28 2005
***************
*** 1,3 ****
! example.1 example.3 example._
! example.1 example.3
! example.1 example.3
--- 1,3 ----
! example._ example.1 example.3
! example.1 example.3
! example.1 example.3
======================================

12)
Creating Difference File ...
run_command_with_output: 'diff -c work/functions/wildcard.base.1 
work/functions/wildcard.log.1' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/functions/wildcard.mk clean' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/functions/wildcard.diff.2
======================================
*** work/functions/wildcard.base.2      Wed Mar 16 23:36:28 2005
--- work/functions/wildcard.log.2       Wed Mar 16 23:36:28 2005
***************
*** 1 ****
! rm example.1 example.3 example._ example.for example.two
--- 1 ----
! rm example._ example.1 example.3 example.for example.two
======================================


13)
options/dash-C .......................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f options/dash-C.mk -C 
work clean' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/dash-C.diff

*** only failing because of incorrect dash-C.base creation with missing 
C:/msys/1.0


14)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/options/dash-I.mk 
-I work recurse' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/dash-I.diff.2

*** only failing because of incorrect dash-C.base creation with missing 
C:/msys/1.0

15)
options/dash-l .......................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/options/dash-l.mk 
-l 0.0001 -j 4' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/dash-l.diff
==================================
*** work/options/dash-l.base    Wed Mar 16 23:36:36 2005
--- work/options/dash-l.log     Wed Mar 16 23:36:36 2005
***************
*** 0 ****
--- 1 ----
+ TWO FAILED
==================================

16)

options/symlinks ........................................ 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk' returned 0.
Comparing Output ........ ok
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk -L' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/symlinks.diff.1
==================================
*** work/options/symlinks.base.1        Wed Mar 16 23:36:38 2005
--- work/options/symlinks.log.1 Wed Mar 16 23:36:38 2005
***************
*** 1 ****
! make targ from sym
--- 1,2 ----
! make: Symbolic links not supported: disabling -L.
! make: `targ' is up to date.
==================================


17)
Creating Difference File ...
run_command_with_output: 'diff -c work/options/symlinks.base.1 
work/options/symlinks.log.1' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/symlinks.diff.2
==================================
*** work/options/symlinks.base.2        Wed Mar 16 23:36:38 2005
--- work/options/symlinks.log.2 Wed Mar 16 23:36:38 2005
***************
*** 1 ****
! make targ from sym
--- 1 ----
! make: `targ' is up to date.
==================================


18)
Creating Difference File ...
run_command_with_output: 'diff -c work/options/symlinks.base.2 
work/options/symlinks.log.2' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk -L' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/symlinks.diff.3
==================================
*** work/options/symlinks.base.3        Wed Mar 16 23:36:38 2005
--- work/options/symlinks.log.3 Wed Mar 16 23:36:38 2005
***************
*** 1 ****
! make targ from sym
--- 1,2 ----
! make: Symbolic links not supported: disabling -L.
! make: `targ' is up to date.
==================================


19)
Creating Difference File ...
run_command_with_output: 'diff -c work/options/symlinks.base.3 
work/options/symlinks.log.3' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk' returned 0.
Comparing Output ........ ok
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk -L' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/symlinks.diff.5
==================================
*** work/options/symlinks.base.5        Wed Mar 16 23:36:38 2005
--- work/options/symlinks.log.5 Wed Mar 16 23:36:38 2005
***************
*** 1 ****
! make: `targ' is up to date.
--- 1,2 ----
! make: Symbolic links not supported: disabling -L.
! make: `targ' is up to date.
==================================


20)
Creating Difference File ...
run_command_with_output: 'diff -c work/options/symlinks.base.5 
work/options/symlinks.log.5' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk' returned 0.
Comparing Output ........ ok
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/options/symlinks.mk -L' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/options/symlinks.diff.7
==================================
*** work/options/symlinks.base.7        Wed Mar 16 23:36:38 2005
--- work/options/symlinks.log.7 Wed Mar 16 23:36:38 2005
***************
*** 1 ****
! make targ from sym
--- 1,2 ----
! make: Symbolic links not supported: disabling -L.
! make: `targ' is up to date.
==================================

21)
targets/DEFAULT ......................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/targets/DEFAULT.mk 
bar' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/targets/DEFAULT.diff
==================================
==================================

*** only failing because of incorrect dash-C.base creation with missing 
C:/msys/1.0

22)
variables/CURDIR ........................................ 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/CURDIR.mk' returned 0.
Comparing Output ........ DIFFERENT OUTPUT
base_file work/variables/CURDIR.base
diff_file work/variables/CURDIR.diff

*** only failing because of incorrect base with missing C:/msys/1.0


23)
ariables/MAKE .......................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f work/variables/MAKE.mk' 
returned 0.
Comparing Output ........ DIFFERENT OUTPUT
base_file work/variables/MAKE.base
diff_file work/variables/MAKE.diff

*** only failing because of incorrect base with missing C:/msys/1.0


24)

run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/SHELL.mk.1' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/variables/SHELL.diff.1
==================================
*** work/variables/SHELL.base.1 Wed Mar 16 23:36:44 2005
--- work/variables/SHELL.log.1  Wed Mar 16 23:36:44 2005
***************
*** 1 ****
! /C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh.exe
--- 1 ----
! C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh.exe
==================================


echo bug!

25)
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/SHELL.mk.2' returned 0.
Comparing Output ........ DIFFERENT OUTPUT
base_file work/variables/SHELL.base.2
diff_file work/variables/SHELL.diff.2


==================================
*** work/variables/SHELL.base.2 Wed Mar 16 23:36:44 2005
--- work/variables/SHELL.log.2  Wed Mar 16 23:36:44 2005
***************
*** 1 ****
! /C:/msys/1.0/bin/sh.exe /C:/msys/1.0/bin/sh.exe
--- 1 ----
! C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh.exe
==================================


26)

run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/SHELL.mk.3' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/variables/SHELL.diff.3
=========================
*** work/variables/SHELL.base.3 Wed Mar 16 23:36:44 2005
--- work/variables/SHELL.log.3  Wed Mar 16 23:36:44 2005
***************
*** 1 ****
! /C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh.exe
--- 1 ----
! C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/s
=========================

27)
Creating Difference File ...
run_command_with_output: 'diff -c work/variables/SHELL.base.3 
work/variables/SHELL.log.3' returned 256.
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/SHELL.mk.4' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/variables/SHELL.diff.4
=========================
*** work/variables/SHELL.base.4 Wed Mar 16 23:36:44 2005
--- work/variables/SHELL.log.4  Wed Mar 16 23:36:44 2005
***************
*** 1 ****
! /C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh.exe
--- 1 ----
! C:/msys/1.0/bin/sh.exe C:/msys/1.0/bin/sh

=========================

28)
variables/special ....................................... 
run_command_with_output: 'C:/msys/1.0/local/bin/make -f 
work/variables/special.mk' returned 0.
Comparing Output ........ DIFFERENT OUTPUT

diff_file work/variables/special.diff
=========================
*** work/variables/special.base Wed Mar 16 23:36:46 2005
--- work/variables/special.log  Wed Mar 16 23:36:46 2005
***************
*** 1,3 ****
! X1 =
! X2 = FOO
! LAST = BAR FOO
--- 1,3 ----
! X1 = FOO
! X2 = FOO
! LAST = BAR FOO
=========================



Index: main.c
===================================================================
RCS file: /cvsroot/make/make/main.c,v
retrieving revision 1.200
diff -u -r1.200 main.c
--- main.c      9 Mar 2005 19:21:34 -0000       1.200
+++ main.c      19 Mar 2005 01:24:07 -0000
@@ -1052,15 +1052,20 @@
             {
               /* Remove .exe extension */
               p[argv0_len - 4] = '\0';
-              /* Increment past the initial '\' */
-              program = p + 1;
+              program = p;
             }
         }
 #endif
       if (program == 0)
        program = argv[0];
       else
-       ++program;
+       {
+          int str_len_p = strlen(program);
+           if(str_len_p > 1)
+                 ++program;
+           else
+             program = "make";
+       }
     }
 
   /* Set up to access user data (files).  */

Attachment: make_msvc.net2003_sln_vcproj..zip
Description: Zip archive


reply via email to

[Prev in Thread] Current Thread [Next in Thread]