Re: [Maposmatic-dev] [PATCH] [v2][ocitysmap] Mapnik 2+: update INSTALL and get rid of DeprecationWarning

[Maxime Petazzoni]

* Jeroen van Rijn <address@hidden> [2012-04-04 20:44:42]:

> >> +import mapnik
> >
> > No assert here?
> I understood from Thomas's remarks that those asserts weren't needed
> because of what loads what, that is the two files with asserts would
> have already had them fire.
> I'll add them back in in those files, but keep the note to the two
> files that now have them.

My bad for not having read the other discussion first. I think we should
have the asserts indeed, just in case someone directly imports one of
our modules.

> I'll also change the assert to check against 2.1-pre or later, as per
> David's remarks about the printable stylesheet.
> 
> v3 of the patch will find its way to the list before too long. Thanks
> for your review.

Sounds good. Thanks for the patch!

/Max
-- 
Maxime Petazzoni <http://www.bulix.org>
 ``One by one, the penguins took away my sanity.''
Writing software in California

signature.asc
Description: Digital signature