maposmatic-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 4/4] Read the GIS database lag from a local


From: Thomas Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH 4/4] Read the GIS database lag from a local file
Date: Thu, 19 Apr 2012 09:09:00 +0200

Le Thu, 19 Apr 2012 09:03:00 +0200,
David MENTRE <address@hidden> a écrit :

> We should call f.close(), shouldn't we? Or, once again, I haven't
> understood how Python works. :-)

Ah, correct.

> It might be better to use the "try: ... with" construct as used by
> Maxime:
> http://git.savannah.gnu.org/cgit/maposmatic/ocitysmap.git/tree/ocitysmap2/layoutlib/abstract_renderer.py#n108

Yes, the with construct seems more appropriate, will fix my patch with
a followup patch, thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni                http://thomas.enix.org
MapOSMatic                      http://www.maposmatic.org
Logiciels Libres à Toulouse     http://www.toulibre.org
Embedded Linux                  http://www.free-electrons.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]