FLAC ntohl patch (was Re: [Mingw-cross-env-list] Preparation of Release 2.16)

[Tony Theodore]

On 6 October 2010 23:31, DiAppoggio <address@hidden> wrote:
> Il 06/10/2010 14:24, Volker Grabsch ha scritto:
>>
>> DiAppoggio<address@hidden>  schrieb:
>>
>>>
>>>
>>> /opt/mingw/usr/lib/gcc/i686-pc-mingw32/4.5.1/../../../../i686-pc-mingw32/lib/libFLAC.a(bitreader.o):/opt/mingw/tmp-flac/flac-1.2.1/src/libFLAC/bitreader.c:274:
>>> more undefined references to address@hidden' follow
>>> collect2: ld returned 1 exit status
>>> make: *** [scummvm.exe] Errore 1*
>>>
>>> After googling I've found that this patch (
>>>
>>> http://sourceforge.net/tracker/?func=detail&atid=313478&aid=1761712&group_id=13478
>>> ) resolves this issue (in my setup of course). I post to the list if
>>> someone can find it useful.
>>>
>>
>> This patch dates back to 2007 and is still not included in the current
>> version of FLAC?
>>
>>
>> Greets,
>> Volker
>>
>>
>
> This patch isn't still included in latest flac-1.2.1 , maybe for devs this
> issue with mingw isn't really a serious issue.

It looks as though it would break a VS build, so it can't really be
applied as-is to their tree. It's also not entirely clear why the:

#elif defined __MINGW32__
#include <winsock.h> /* for ntohl() */

doesn't work as expected (a few lines after the first patch hunk). It
probably needs some more thought.

Cheers,

Tony