[Mldonkey-bugs] [bug #13891] Sancho is not showing when a file has been downloaded before

[spiralvoice]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=13891>

                 Summary: Sancho is not showing when a file has been
downloaded before
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: None
            Submitted on: Sam 23.07.2005 um 09:35
                Category: Core
                Severity: 3 - Normal
              Item Group: Program malfunction
                  Status: Wont Fix
             Assigned to: None
             Open/Closed: Open
                 Release: 2.6.0
                 Release: 
        Platform Version: Linux
         Binaries Origin: CVS / Self compiled
                CPU type: Intel x86

    _______________________________________________________

Details:

Hello,

There is some kind of bug with the core that makes sancho not display in the
"search" window when a file has been downloaded before. The previously
downloaded files should be green.

NOTE: Sent this bug to sancho's development team before, but they said this is
a core problem, since it works as expected with knocker's core releases.


If you need any more info, you can contact me here:

metralla at redleader.dyndns.org



    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Mon 25.07.2005 um 15:26       By: Anonymous
"Each branch has its pro and cons, there is no wrong or right. "

Yeah. Sorry if it looked i was talking about all the branch. I was thinking
about the "keep_cancelled_in_old_files" option when I said that.

About adding another option called "keep_downloaded_in_old_files", I think
that is the approach that will make everyone happy.




-------------------------------------------------------
Date: Mon 25.07.2005 um 15:09       By: spiralvoice <spiralvoice>
"Sorry, went back to mulus. Seems to be working better for me at this point of
development (not just for this issue). "
No problem.

"No matter how long have you been walking on the wrong path, come back and
pick the right one."
Each branch has its pro and cons, there is no wrong or right.
Even more, I think there is never a right path, there are always
alternatives, but this is too philosophical for MLDonkey bug tracker ;-)

"Suppose you change the code so commited files always go to oldfiles"
I don´t want to let MLDonkey keep a record of all files I download.

The only change would be a new option: keep_downloaded_in_old_files.

"always use the force_download command to do it (assuming it was not removed
from the 2.6 branch). "
Its there and alive.

-------------------------------------------------------
Date: Mon 25.07.2005 um 11:50       By: Anonymous
Sorry, went back to mulus. Seems to be working better for me at this point of
development (not just for this issue).

About the incorrect code, I dont know who put it there or when, but I would
fix it anyway. No matter how long have you been walking on the wrong path,
come back and pick the right one.

Suppose you change the code so commited files always go to oldfiles, and
cancelled files only go to oldfiles if keep_cancelled_in_old_files is
enabled.
Think about the possible situations:

1) You have it "enabled" now. 
Current behavior: Both commited and cancelled files are added to oldfiles
New behavior: The same.

2) You have it "disabled" now.
Current behavior: No files are added to oldfiles.
New behavior: Commited files are always added to oldfiles, cancelled files
will not be added to oldfiles.

In the first case there is no difference.
In the second case, there is a difference, but its really not much problem.
Most people will never want to download the same file twice, and if they
really need to (because they deleted it by mistake or whatever), they can
always use the force_download command to do it (assuming it was not removed
from the 2.6 branch).





-------------------------------------------------------
Date: Mon 25.07.2005 um 09:49       By: spiralvoice <spiralvoice>
"add to the oldfiles the ones cancelled"
I know, but when looking where keep_cancelled_in_old_files is used
came across this code in donkeyInteractive.ml:

  file_ops.op_file_commit <- (fun file new_name ->
      if !!keep_cancelled_in_old_files
          && not (List.mem file.file_md4 !!old_files) then
        old_files =:= file.file_md4 :: !!old_files;

So old_files is also filled with committed files, I don´t by whom
and when this was changed but it seems to be implemented.
Please test this behaviour, if it works for you I will change the
description of this option, changing the option name without
resetting the option for all users is not possible IMHO.

-------------------------------------------------------
Date: Son 24.07.2005 um 21:29       By: Anonymous
In previous mldonkey releases, the keep_cancelled_in_old_files option just
made the core to add to the oldfiles the ones cancelled, even if they were not
downloaded.

If you changed that behavior on purpose, i recommend you change the name of
that option to something that reflects what it does now, or at least document
it.



-------------------------------------------------------
Date: Son 24.07.2005 um 21:17       By: spiralvoice <spiralvoice>
"ED2K-keep_cancelled_in_old_files was not enabled"
"old_files = [] thing and its empty"
its not a bug, its a feature, you have to enable
ED2K-keep_cancelled_in_old_files,
otherwise information about downloaded files is not saved, without
that thr core is not able to show "when a file has been downloaded before"

-------------------------------------------------------
Date: Son 24.07.2005 um 19:59       By: Anonymous
ED2K-keep_cancelled_in_old_files was not enabled, but the file I searched for
was just downloaded and commited.

I took a look at the  old_files = [] thing and its empty, but the core has not
stopped since I downloaded this. Does it write the ini's only at shutdown?



-------------------------------------------------------
Date: Son 24.07.2005 um 17:18       By: spiralvoice <spiralvoice>
Do you have ED2K-keep_cancelled_in_old_files enabled?

Are there entries here in donkey.ini:

        (* The files that were downloaded *)
 old_files = []

-------------------------------------------------------
Date: Sam 23.07.2005 um 09:37       By: Anonymous
Forgot to say I'm using sancho 0.9.4-44 (latest at this time).






    _______________________________________________________

Carbon-Copy List:

CC Address                          | Comment
------------------------------------+-----------------------------
address@hidden       | 




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=13891>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/