[Mldonkey-bugs] [bug #10062] max_hard_download_rate has to be doubled

[pango]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=10062>

                 Summary: max_hard_download_rate has to be doubled
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: spiralvoice
            Submitted on: jeu 19.08.2004 à 12:49
                Category: Core
                Severity: 3 - Normal
              Item Group: Program malfunction
                  Status: Ready For Test
             Assigned to: spiralvoice
             Open/Closed: Open
                 Release: 2.6.3
                 Release: 
        Platform Version: None
         Binaries Origin: CVS / Self compiled
                CPU type: None

    _______________________________________________________

Details:

This bug is still there:
"2004/05/05: Fabrice (version 2.5.21 = 2.6pre3, tag release-2-5-21) 
   - For some reason, download seems to be limited to
max_hard_download_rate/2. 
       Try to increase this option until a fix is found. "
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=14447#14447

    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: lun 29.08.2005 à 23:44       By: pango <mlpango>
Changed bug status.

-------------------------------------------------------
Date: lun 29.08.2005 à 02:47       By: pango <mlpango>
Updated patch for Bittorrent upload.


-------------------------------------------------------
Date: lun 29.08.2005 à 02:37       By: pango <mlpango>
Bittorrent upload probably has exactly the same bug
(in BTClients.iter_upload, client_uploaded is incremented, then count_upload
is called that also increments client_uploaded)...


-------------------------------------------------------
Date: lun 29.08.2005 à 02:09       By: pango <mlpango>
I think I've found the bug.

Code was added to donkey and bittorrent supports to increment
client_downloaded fields using Swarmer transfer accounting.

Problem is, count_download already updates client_downloaded, so transfers
end up being counted twice.

(Untested) patch attached.


-------------------------------------------------------
Date: ven 10.06.2005 à 02:31       By: spiralvoice <spiralvoice>
According to
https://savannah.nongnu.org/patch/?func=detailitem&item_id=4046#comment1
it works now. As it is fixed I will close this bug.
In the code I left a "TODO" note for later work, no need to have
an open bug report for it now.

-------------------------------------------------------
Date: jeu 26.05.2005 à 12:28       By: spiralvoice <spiralvoice>
see patch #4046

-------------------------------------------------------
Date: mer 04.05.2005 à 09:01       By: su_blanc <su_blanc>
a small comment from the 2.5.30-15 version, seen on the donkey network:
when a source is uploading us data for a file, the downloaded part from the
source is the double of the downloaded part of the file.
You can observe that from the GTK2 GUI:
- add a new file
- expand the file in the GUI to see the sources
- wait for the first source to upload to us
- watch carefully the 'Downloaded' column. The file downloaded size is
*exactly* half of the data downloaded from the source.


-------------------------------------------------------
Date: mer 13.04.2005 à 11:10       By: Anonymous
that patch doesnt actually fix the bug it just hides it

-------------------------------------------------------
Date: mar 12.04.2005 à 13:12       By: spiralvoice <spiralvoice>
Please try the attached patch.







    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: lun 29.08.2005 à 02:47  Name: fix_doubled_download_rates.patch  Size:
4,38Ko   By: mlpango

<http://savannah.nongnu.org/bugs/download.php?item_id=10062&item_file_id=2875>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=10062>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/