[Mldonkey-bugs] [bug #18833] ETN.fm torrent url not added

[spiralvoice]

Update of bug #18833 (project mldonkey):

                  Status:               Duplicate => Ready For Test         
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #4:

dllink http://....

loads HTTP headers with a HEAD request for further inspection.
The tracker mentioned here answers all HEAD requests with error
400 which stops the download process of the torrent file.
I tested this by sending the a GET and a HEAD request with Telnet.

Without a correct header answer MLDonkey does not know what
to do with the URL because dllink is a generic command for all
network modules. All networks are called with the received headers,
BT module has this code to analyze HTTP headers and find the
ones its responsible for:

    if (valid_torrent_extension real_url)
       || (String2.contains url "Content-Type: application/x-bittorrent")

But the error 400 stops the dllink process because it returns
no data worth analyzing.
I attached a patch which repeats a HEAD request as GET in the
lower network module http_client if a HEAD request returned
error 400, please test.

This will lead to the situation that dllink does a GET request
with this URL, BT module parses the headers, finds out that its
responsible for the URL and does a GET request again to get the
torrent file. Because of the generic structures of the common
and net modules in MLDonkey downloading the .torrent file twice
here can not be avoided. Using command "startbt" avoids
downloading the torrent file twice because its especially made
for BT and does a GET request right at away.

(file #11868)
    _______________________________________________________

Additional Item Attachment:

File name: http_400head.patch             Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18833>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/