Re: Memory totals not adding up

[Darhl Thomason]

I got it Martin, it's reporting properly now!

Thanks again for your help and the quick patches!

Darhl

On Tue, Sep 13, 2011 at 5:54 PM, Darhl Thomason <address@hidden> wrote:
> Let me try this and see how it goes.  It's a good learning exercise
> for me since I've never patch source before.
>
>
> On Tue, Sep 13, 2011 at 2:17 PM, Martin Pala <address@hidden> wrote:
>> … if you prefer the binary build (such as monit-5.3-linux-x64.tar.gz), i can 
>> prepare binary fix as well - let me know which platform you need (such as 
>> the linux-x64)
>>
>>
>> On Sep 13, 2011, at 11:14 PM, Martin Pala wrote:
>>
>>> You need to recompile to apply the patch:
>>>
>>>       wget http://www.mmonit.com/monit/dist/monit-5.3.tar.gz
>>>       tar -xzf monit-5.3.tar.gz
>>>       cd monit-5.3
>>>       patch -p0 < mem_percent.patch
>>>       ./configure
>>>       make
>>>       make install
>>>
>>> Best regards,
>>> Martin
>>>
>>>
>>>
>>> On Sep 13, 2011, at 11:09 PM, Darhl Thomason wrote:
>>>
>>>> Fantastic, thanks for getting the patch put together so quickly!
>>>>
>>>> Pardon my inexperience, I've never applied a patch like this.  Do I
>>>> apply it to the source and recompile, do I apply it to the binary?
>>>> I've googled patch and I'm still not quite sure how to apply it.
>>>>
>>>> Thanks again!!!
>>>>
>>>> Darhl
>>>>
>>>> On Tue, Sep 13, 2011 at 1:57 PM, Martin Pala <address@hidden> wrote:
>>>>> You are right, the "memory [kB]" shows the total including children, but 
>>>>> the memory% still shows the process itself.
>>>>>
>>>>> The patch is attached.
>>>>>
>>>>> Best regards,
>>>>> Martin
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sep 13, 2011, at 9:28 PM, Darhl Thomason wrote:
>>>>>
>>>>>> Martin,
>>>>>>
>>>>>> Thanks for having my suggestion included in the 5.3 update.  I applied
>>>>>> it this morning and see that the memory count looks correct, but I
>>>>>> think the % calculation was missed in the update.  It looks like it is
>>>>>> still reporting the % of the main thread only and does not include the
>>>>>> child threads.  The memory % should be somewhere around 15% in the
>>>>>> attached screenshot/example.
>>>>>>
>>>>>> Thanks again!!
>>>>>>
>>>>>> Darhl
>>>>>>
>>>>>> On Sep 1, 2011, at 9:27 AM, Martin Pala <address@hidden> wrote:
>>>>>>
>>>>>> You are right, int he case of the process-based worker pool such as
>>>>>> Apache it is confusing to display only the CPU and Memory usage of the
>>>>>> parent/control process.
>>>>>> We'll modify the overview page to display the resource usage including
>>>>>> children (will work fine even for services without children - in their
>>>>>> case the total memory usage and memory usage are equal).
>>>>>> Best regards,
>>>>>> Martin
>>>>>>
>>>>>> On Aug 30, 2011, at 4:33 AM, Darhl Thomason wrote:
>>>>>>
>>>>>> Martin,
>>>>>>
>>>>>> Thanks for the reply and I now see the 'Total Memory Usage (incl.
>>>>>> children)' on the detail page for the Apache process.  It's a bit
>>>>>> confusing because the top line of the main page shows total memory
>>>>>> used, but when you add up the memory displayed on that page for each
>>>>>> process it doesn't add up.
>>>>>>
>>>>>> Are there any plans or is there any possibility for the main page to
>>>>>> show 'Total Memory Usage (incl. children)'?  I also just noticed that
>>>>>> CPU usage is reported the same way.  The main page only shows CPU for
>>>>>> the single process, but the detail page shows 'Total CPU Usage (incl.
>>>>>> children)'.
>>>>>>
>>>>>> If you have a wishlist, I'd like to add the Total Memory Usage (incl.
>>>>>> children) and Total CPU Usage (incl. children) on the main page.
>>>>>> Maybe have this as an option in the config file so you can do
>>>>>> something like this:
>>>>>> <monit_5.3.png>--
>>>>>> To unsubscribe:
>>>>>> https://lists.nongnu.org/mailman/listinfo/monit-general
>>>>>
>>>>>
>>>>> --
>>>>> To unsubscribe:
>>>>> https://lists.nongnu.org/mailman/listinfo/monit-general
>>>>>
>>>>
>>>> --
>>>> To unsubscribe:
>>>> https://lists.nongnu.org/mailman/listinfo/monit-general
>>>
>>>
>>> --
>>> To unsubscribe:
>>> https://lists.nongnu.org/mailman/listinfo/monit-general
>>
>>
>> --
>> To unsubscribe:
>> https://lists.nongnu.org/mailman/listinfo/monit-general
>>
>