monotone-commits-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-commits-diffs] Revision 617145532aa5499205d7a35a386e2417d512ca


From: monotone
Subject: [Monotone-commits-diffs] Revision 617145532aa5499205d7a35a386e2417d512ca03
Date: Tue, 16 Jan 2007 13:04:38 +0100

-----------------------------------------------------------------
Revision: 617145532aa5499205d7a35a386e2417d512ca03
Ancestor: 202c9b7ef88d565d24908738495de99f59d45d22
Author: address@hidden
Date: 2007-01-16T11:55:20
Branch: net.venge.monotone.guitone

Modified files:
        guitone/src/monotone/Monotone.cpp
        guitone/src/monotone/Monotone.h

ChangeLog: 

Fixed toposort problem - this was actually not a problem of mtn, but of
the monotone wrapper. it emitted the commandFinished() signal too early
before it disconnected from readyRead(). While another command was waiting
to get its command through the wrapper, it wrote the input to the process
already, and then, shortly afterwards, a disconnect() was called from the
previous command which effectively hindered the new command to receive any
output because its connection was removed.

I also put up a big fat FIXME above setupNewCommand, because this function
is not threadsafe at all, but should become so in the future. This makes
problems however, since a normal QMutex with tryLock produces deadlocks
if a user does heavy clicking.

Attachment: txt2ZA4KXZnMU.txt
Description: Diff [202c9b7ef88d565d24908738495de99f59d45d22] -> [617145532aa5499205d7a35a386e2417d512ca03]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]