[Monotone-devel] Re: MinGW patch

[Jon Bright]

graydon hoare wrote:

> Jon Bright wrote:
>
> > --- ../monotone-pulled/monotone.cc      Mon Mar 29 17:52:22 2004
> > +++ monotone.cc Tue Mar 30 14:16:26 2004
> > @@ -136,6 +136,8 @@
> >    bindtextdomain(PACKAGE, LOCALEDIR);
> >    textdomain(PACKAGE);
> >
> > +  fs::path::default_name_check(fs::native);
> > +
>
>
> huh. that's strange. I thought I was using mkpath() to build paths 
> everywhere, which does the fs::native check as part of it. could you 
> perhaps pick out the place where it was making a path and *not* calling 
> mkpath()?

I initially tried fixed the first one I found, but after finding another 
two (three?), came to the conclusion that it was more of a general issue 
and gave up on that in favour of this general fix.  As an example, in 
app_state::set_database():

db.set_filename(filename());

would become

db.set_filename(mkpath(filename()));

Because set_filename takes an fs::path, which with the code as-is, is 
implicitly constructed from filename, which is a utf8.

Is there some disadvantage to the more general fix which is avoided by 
mkpath?

--
Jon Bright
Silicon Circus Ltd.
http://www.siliconcircus.com