[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: comments on win32 patches

From: Christof Petig
Subject: Re: [Monotone-devel] Re: comments on win32 patches
Date: Mon, 28 Feb 2005 16:52:48 +0100
User-agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.7.5) Gecko/20050105 Debian/1.7.5-1

Jon Bright schrieb:
Similarly, I'd be tempted to just have a spawn_and_wait interface, but
I suppose spawn_with_pipes needs something different... though we
should see exactly what's needed to support spawn_with_pipes(), hook
it up to netxx, etc.

I definitely think spawn() and wait() should be different functions.  I
can easily imagine hooks (note_commit, for example) wanting to spawn
some external mail job or similar, and really not caring when it ends. I
planned to look at Christof's stuff to get an idea of what's needed for
spawn_with_pipes() - but it definitely doesn't want wait(), and I don't
think it wants any links to netxx..

Actually it does. Netxx is the layer used by netsync and that is exactly
what the ssh branch covers.

For the cvssync branch I chose to implement first (using
pipe+socket+write+al.), port later, but I would have chosen Netxx
because I need a common abstraction for spawn_with_pipes (CVS_RSH) and
socket+connect (pserver) and was familiar with Netxx from the ssh branch.

So actually Netxx would be the layer to target (or any other socket+pipe
capable abstraction).


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]