[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Log message file (MT/log) patch

From: Jeremy Cowgar
Subject: Re: [Monotone-devel] Log message file (MT/log) patch
Date: Sun, 20 Mar 2005 22:44:35 -0800
User-agent: Wanderlust/2.12.2 (99 Luftballons) Emacs/21.4 Mule/5.0 (SAKAKI)

Nathaniel Smith <address@hidden> wrote:

> > +function edit_comment(basetext, user_log_message)
> >     local exe = "vi"
> >     local visual = os.getenv("VISUAL")
> >     if (visual ~= nil) then exe = visual end
> > @@ -74,6 +74,7 @@
> >     if (tmp == nil) then return nil end
> >     basetext = "MT: " .. string.gsub(basetext, "\n", "\nMT: ") .. "\n"
> >     tmp:write(basetext)
> > +   tmp:write(user_log_message)
> >     io.close(tmp)
> I think I'd prefer to have the user_log_message go _first_ in the
> file?  Maybe I'm weird, but I usually write my message above the "MT:"
> stuff, since that's where my cursor starts.  Anyone else have a
> preference here?

I may have already commented on this by creating the code, but I'll
give you my reasoning and it can be tossed into discussion.

The MT: lines provides a summary of what you've done. I tend to skim
down though it refreshing my mind incase I have forgot anything, then
I write my log change message. So it was just a natural progression
for me. This is obviously very easy to change in the code, so from a
coding standpoint, it does not matter, but from a user standpoint,
well, let the discussion continue!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]