[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Patch
From: |
Bernhard Reiter |
Subject: |
Re: [Monotone-devel] Patch |
Date: |
Wed, 13 Apr 2005 17:06:18 +0200 |
User-agent: |
Mutt/1.5.6i |
On Wed, Apr 13, 2005 at 03:26:05PM +0200, Sebastian Spaeth wrote:
> - Before it would always show full kb if bytes is > 16kb.
> I modified it to show kb or MB with one decimal after the comma.
Actually your patch uses KiB not kB
and MiB instead of MB
as far as I can see. :)
Seriously I learned that messing with the universal 10^3 based
prefix SI-system is not a good idea. So I would prefer kilobyte
and megabyte over kibibyte and mebibyte. If you really must use KiB,
why not label it correctly?
> + sess.byte_in_ticker.reset(new ticker("bytes in", ">", 1024, true));
> - div = 1024;
> - suffix = "k";
> + // ticks >=1MB, use Mb
> + div = 1048576;
pgpdFwmYPpwK7.pgp
Description: PGP signature