[Monotone-devel] Push can pretend it is successful while it is not

[Marcel van der Boom]

A couple of days ago one of our developers tried to push a couple of  
changes to our database, which looked like it succeeded. However, no  
notice was sent out and the revision was not visible in the viewmtn  
web interface. After investigating the revision looked like it was  
"half pushed" leaving a database behind which gave "serious errors"  
on a db check.

The sequence of events  was roughly as follows:

1.
  $ monotone push mt.xaraya.com:15000 com.xaraya.modules.tinymce
  monotone: connecting to mt.xaraya.com:15000
  monotone: rebuilding merkle trees ...
  monotone: including branch com.xaraya.modules.tinymce
  monotone:   certs |    keys
  monotone:    1659 |       4
  enter passphrase for key ID address@hidden:
  monotone: bytes in | bytes out | certs out | revs out
  monotone:    20.6k |     70.3k |         4 |        1
  monotone: read from fd 1924 (peer mt.xaraya.com:15000) closed OK  
after goodbye

So, this looks like it ran successfull, right?

2. Looking on the server in the log file, this push corresponed with:
monotone: accepted new client connection from 211.26.55.120:3837
monotone: allowed 'address@hidden' read permission for  
'com.xaraya.modules.tinymce' excluding ''
monotone: allowed 'address@hidden' write permission for  
'com.xaraya.modules.tinymce' excluding ''
monotone: rebuilding merkle trees ...
monotone: ticks: c="certs"/256, k="keys"/1
monotone:
monotone: warning: discarding revision cert packet  
0b45d6ed5ad415e822b64364eaa87cc865d07b34 with unmet dependencies
monotone: error: sqlite error [5]: database is locked

That sounds a bit less successful already.

3. monotone db check came up with all sorts of reference errors missing

4. I asked jojo to push again, it failed

5. I asked her to try again, while i enabled debugging (so server  
instance was restarted) to see what was going on.

6. The push succeeded (!?) O_O

7. monotone db check returns no failures after the push.


The self repairing feature is of course very nice ;-) but what would  
have happened if people would have pulled the database in the mean  
time? It looks like the 'metadata' of the revision(s) was registered  
in the database, but the actual changes were not applied. What  
happened here?

marcel

PS
Can I request you guys install a proper bugtracker? The one at  
savannah doesnt really do the job imho.  Bugzilla seems fitting for a  
project like monotone.


--
Marcel van der Boom
HS-Development BV               --   http://www.hsdev.com
So! webapplicatie framework  --   http://make-it-so.info

smime.p7s
Description: S/MIME cryptographic signature