[Monotone-devel] Re: monotone disapprove does not give correct branch cert

[Bruce Stephens]

Emile Snyder <address@hidden> writes:

> approve
> disapprove
> checkout
> commit
>
> I would argue that only commit should default to using the working copy
> value if one is set.  approve and disapprove both take a revision as a
> specific argument; I can sort of see using the value of the working copy
> branch if that given revision has no branch cert, but not the other way
> around.

I'm unconvinced that disapprove ought to do that.  Surely it ought to
use the branches that are on the original revision, maybe giving a
warning if there aren't any?  (I guess branchless revisions are
unusual enough to merit at least a warning?)  Overridable by the
--branch option, I guess.

Unless I'm missing something, it's easy enough to add a branch cert if
one is really wanted; I'm dubious that using the one in the working
copy is going to make any sense (unless it's already on the original
revision).

[...]