monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [patch] adding branchname to parameters for validat


From: Nathaniel Smith
Subject: Re: [Monotone-devel] [patch] adding branchname to parameters for validate_commit_message
Date: Mon, 18 Sep 2006 13:21:16 -0700
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Sep 18, 2006 at 07:35:08PM +0200, Marcel van der Boom wrote:
> Included is a small patch which adds branchname as a third parameter  
> for the validate_commit_message.

Looks fine to me, except you left out the tests ;-).

(See tests/commit_validation_lua_hook and I guess
tests/i18n_commit_messages maybe should be updated for consistency.)

-- Nathaniel

-- 
Eternity is very long, especially towards the end.
  -- Woody Allen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]