[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] FreeBSD port patches

From: Zack Weinberg
Subject: Re: [Monotone-devel] FreeBSD port patches
Date: Sat, 23 Sep 2006 16:11:59 -0700

On 9/23/06, Lapo Luchini <address@hidden> wrote:

   if (!init)
       setlocale(LC_ALL, "");
+#ifdef ENABLE_NLS
       bindtextdomain(PACKAGE, LOCALEDIR);
       init = 1;

It would be better to put something like

#ifndef ENABLE_NLS
inline char * textdomain(char *) { return 0; }
inline char * bindtextdomain(char *, char *) { return 0; }

just above localize_monotone(); #ifdefs in the middle of a function
are to be avoided.

-       $(CXXLINK) $(mtn_LDFLAGS) $(mtn_OBJECTS) $(mtn_LDADD) $(LIBS)
+       $(CXXLINK) $(mtn_LDFLAGS) $(mtn_OBJECTS) $(mtn_LDADD) $(LIBS)  

As Nathaniel said, you need to modify not (the
latter is a generated file) ... however, this should not be necessary
at all, as we already have $(LIBICONV) and $(LIBINTL) in the various
prog_LDADD variables.  If that's not working, please let us know.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]