Re: [Monotone-devel] Merging nvm.ssh-agent to mainline

[Justin Patrin]

On 2/27/07, Matthew Gregan <address@hidden> wrote:
> At 2007-02-27T13:10:30-0800, Justin Patrin wrote:
> > Compiled in msys it works fine, although I haven't run the tests on the
> > latest and greatest (I'll do it now just to me sure).
>
> Huh, really?  Is nvm.ssh-agent up-to-date with mainline, because the
> unset_env addition in tester.cc fails to build for me on MinGW because
> unsetenv(3) is not available.  The fix is obvious (split unsetenv() out into
> platform.hh and unix/win32 dirs and find a suitable replacement for Win32),
> but I haven't had time to do it yet.

Yep, that change broke my msys build. It did work before I put that
in, however. I have a fix for this now based on the code for setenv
that is in tester.cc and will push it in a minute.

BTW, I'm not sure if platform.hh is the best place for this as this is
tester-only code, not used in mtn itself.

> > I don't have Visual Studio so I don't know if it works with that (*does*
> > monotone compile in VC++?)
>
> It used to, with VS2005, as of fd287f225d5c1222b160b3049e6192583d150d82,
> which was around a year ago.  It pretty much hasn't been touched since,
> except for whatever progress Larry made during the summit.  I've been
> meaning to sit down and look at it too, but haven't had time yet.  I
> wouldn't worry about it for nvm.ssh-agent for now, as long as MinGW is okay.

--
Justin Patrin