monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Last test to fix!


From: Nathaniel Smith
Subject: Re: [Monotone-devel] Last test to fix!
Date: Tue, 27 Feb 2007 17:40:28 -0800
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Feb 27, 2007 at 02:28:13PM +0100, Richard Levitte - VMS Whacker wrote:
> Hi,
> 
> I've one last test to fix, ws_ops_with_wrong_node_type .  It fails at
> line 19, and honestly, this test looks weird!  First, the directory
> "dir2" is created but not added (therefore not versioned), then
> there's an attempt to rename the file "file" into that unversioned
> directory, and it was apparently expected to succeed!  Did monotone
> really allow that, ever?  Would it make sense for it to allow such an
> operation?
> 
> I'm thinking that if monotone ever allowed a versioned file to be
> renamed into an unversioned directory, it is a bug that has apparently
> been corrected since.  I'm changing the test accordingly.

Theory -- it was doing something like
 $ mkdir foo
 $ touch bar
 $ mtn add bar
 $ mtn mv bar foo
And expecting that mtn would, at the end of this, expect that there
existed a file (not directory) named "foo", that should be versioned?
Hence the test's name, which suggests that it is somehow testing what
happens when mtn and the workspace disagree on the file vs. directory
status of some versioned entity?

-- Nathaniel

-- 
Electrons find their paths in subtle ways.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]