Re: [Monotone-devel] exit code of '1' in 0.37 win32 version when using ssh-agent signature

[Stephen Leake]

Matthew Gregan <address@hidden> writes:

> The problem turned out to be pretty simple but kinda ugly.  platform.hh
> includes $platform/ssh_agent_platform.hh, where $platform is unix or win32.
> The test to switch includes was using a non-existent define (WIN32_PLATFORM,
> which is an Automake conditional, not a define) and we ended up including
> unix/ssh_agent_platform.hh on every platform.  We still ended up executing
> the code in win32/ssh_agent_platform.cc because we compile and link the
> contents of win32/ on Windows and unix/ everywhere else.
>
> Fixed in 8d79f29eef6f1d9fef3eeaa30166fb63d684fbbf.

This exposed a bug in win32 ssh_agent_platform::connect - it was not
initializing filemap to NULL if the Pageant window is not found.

Also, tester.cc requires an #include <vector.hh>

Fixed in 502579595c49bcc4844b2594049a19ed757e6b5f

-- 
-- Stephe