[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] BUG: "mtn diff" vs. "diff" with respect to not exis
|
From: |
Ralf S. Engelschall |
|
Subject: |
Re: [Monotone-devel] BUG: "mtn diff" vs. "diff" with respect to not existing trailing newline on last line |
|
Date: |
Tue, 4 Mar 2008 07:23:57 +0100 |
|
User-agent: |
Mutt/1.5.17 OpenPKG/CURRENT (2007-11-01) |
On Mon, Mar 03, 2008, Zack Weinberg wrote:
> On Mon, Mar 3, 2008 at 10:33 PM, Nathaniel Smith <address@hidden> wrote:
> > On Mon, Mar 03, 2008 at 10:53:25PM +0100, Ralf S. Engelschall wrote:
> > > The appended patch successfully resolves the bug for me.
> >
> > Looks fine in principle, but *really* needs some tests added...?
>
> Agree; also, should we *ever* be emitting added lines before deleted
> lines for any given sub-chunk?
Well, I was surprised myself by discovering this code and the fact that
it first output added and then deleted lines and not vice versa. I've no
clue why this code is this way. But tests will show up more...
Ralf S. Engelschall
address@hidden
www.engelschall.com