[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] mainline unit tests fixed

From: Stephen Leake
Subject: Re: [Monotone-devel] mainline unit tests fixed
Date: Wed, 26 Mar 2008 04:49:57 -0400
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (windows-nt)

"Zack Weinberg" <address@hidden> writes:

> On Tue, Mar 25, 2008 at 4:48 PM, Markus Schiltknecht <address@hidden> wrote:
>>  I've hopefully fixed the two tests, which were failing on mainline. The
>>  first, non_workspace_keydir, one was failing, because it expected no
>>  keys in the keydir. If you had some in $HOME/keys, it failed. I've
>>  solved this by creating an empty directory and setting $HOME to that.
> Ick.  Why are we even looking at $HOME in the testsuite?  

The short answer is "because there's no way to tell mtn not to".

We could try to add a "--no-defaults" option that would disable
checking $HOME. But that would mean we are never testing that portion
of the mtn code. We recently had an example of a change in netsync
that passed all the test suites, but failed on a typical user setup.
So we need more tests that assume a typical $HOME.

I think Markus' fix is better. Then we can also put specific stuff in
the $HOME directory, to test the behavior in those cases.

We should experiment with adding that $HOME fix to the core 'safe_mtn'
command; carefully, of course :).

>>  The second one took me more than an hour, because my knowledge of the
>>  ssh_agent is pretty uhm.. non-existent. Anyway, it turned out, that
>>  removing "--ssh-sign=no" from safe_mtn() in lua-testsuite.lua did the trick.
>>  It looks like Stephen added that in revision d7b34554...  I cannot see
>>  any reason for that addition, so I've removed it again.

I apologize for that; thanks for fixing it.

As I said in my other post, I now realize that I did not do a good job
of checking to see if that caused any tests to fail on the buildbots.

Does this mean there may be an issue with the ssh tests depending on
some user ssh keys?

-- Stephe

reply via email to

[Prev in Thread] Current Thread [Next in Thread]