Re: [Monotone-devel] Monotone 0.40 and SSH-Agent: broken?

[Justin Patrin]

On Sat, Apr 12, 2008 at 9:28 AM, Justin Patrin <address@hidden> wrote:
> On Sat, Apr 12, 2008 at 12:54 AM, Ralf S. Engelschall
>
>
> <address@hidden> wrote:
>  >
>  > On Sat, Apr 12, 2008, Ralf S. Engelschall wrote:
>  >
>  >  > On Fri, Apr 11, 2008, Justin Patrin wrote:
>  >  >
>  >  > > On Fri, Apr 11, 2008 at 2:02 PM, Ralf S. Engelschall
>  >  > > <address@hidden> wrote:
>  >  > > > On Fri, Apr 11, 2008, Ralf S. Engelschall wrote:
>  >  > > >
>  >  > > >  > After upgrading to Monotone 0.40 and migrating my databases to 
> the new
>  >  > > >  > schema with "mtn db migrate" I'm faced with the problem that on 
> "mtn
>  >  > > >  > commit" I'm now asked for the pass-phrase of my address@hidden 
> key,
>  >  > > >  > although it is loaded just fine in the SSH-Agent and could be 
> fetched
>  >  > > >  > just fine by all Monotone <= 0.39 during the last months. It 
> seems to be
>  >  > > >  > that the code which uses the SSH-Agent got broken in Monotone 
> 0.40 with
>  >  > > >  > the recent changes. Any clues?
>  >  > > [...]
>  >  > >
>  >  > > Can you try running a "make check" and see if the ssh-agent tests
>  >  > > fail? I'm not seeing any failures on my machines.
>  >  >
>  >  > This is the really strange thing, the test suite works just fine:
>  >  >
>  >  > | [...]
>  >  > | 413 ssh_agent                                     ok
>  >  > | [...]
>  >  >
>  >  > Seems like I've to digg deeper to find out why 0.40 now dislikes my key
>  >  > in the SSH-Agent. My current situation now is:
>  >  >
>  >  > | $ mtn ci -m "upgrade to RPM 5.1b2"
>  >  > | mtn: beginning commit on branch 'OpenPKG.framework.src'
>  >  > | enter passphrase for key ID address@hidden:
>  >  > | mtn: committed revision 7b7299dbfcd62ad95ebc5ce38ac4fdef4268ae27
>  >  > | address@hidden:/u/rse/prj/openpkg-2008/src/openpkg/src
>  >  > | $ ssh-add -l
>  >  > | 1024 94:bb:05:92:32:ef:11:65:ec:aa:d5:2e:97:82:53:c7 Ralf S. 
> Engelschall <address@hidden> (RSA1)
>  >  > | 2048 27:cc:cb:66:10:31:09:03:9e:0d:de:31:fd:6b:c0:7f Ralf S. 
> Engelschall (DSA) (DSA)
>  >  > | 2048 d8:68:a2:f8:90:13:10:2f:f2:2e:64:f5:8e:1d:6d:b3 Ralf S. 
> Engelschall (RSA) (RSA)
>  >  > | 1024 89:46:ab:e9:ae:eb:7b:8a:43:0c:2b:eb:95:f2:58:24 address@hidden 
> (RSA)
>  >  >
>  >  > The last key in my SSH-Agent is the RSA key for Monotone which worked
>  >  > just fine during the last months. But as you can see from my commit
>  >  > step before, Monotone no longer seems to contact my SSH-Agent (which
>  >  > here is based on PAgent from PuTTY). I don't know why. Exactly the
>  >  > same PAgent process is what I used with Monotone 0.39 just yesterday
>  >  > before I upgraded to Monotone 0.40, the I've definetely no change on the
>  >  > SSH-Agent side.
>  >  >
>  >  > Strange, I'll try to find out what is going on here...
>  >
>  >  Ok, could it be that the "ssh_agent" test suite is broken? I mean it
>  >  seems to me that it just tries to load a pass-phrase protected key
>  >  into the agent, but I do not see where it actually tries to perform a
>  >  _commit_ operation with this key. When I add...
>  >
>  >  Index: tests/ssh_agent/__driver__.lua
>  >  --- tests/ssh_agent/__driver__.lua  
> 95cd8c83271295eacfdafa032182f9ee07ae1913
>  >  +++ tests/ssh_agent/__driver__.lua  
> d8c108b85e3c9720e8c5d1cd91e4e1754c2e104d
>  >  @@ -290,3 +290,8 @@ end
>  >   if not ok then
>  >     err("identity was not added to ssh-agent")
>  >   end
>  >  +
>  >  +-- * (ok) mtn ci with -k and with ssh-agent running with both montone 
> keys ex/imported key with passphrase
>  >  +addfile("some_file21", "test")
>  >  +check(mtn("ci", "--key", "address@hidden", "--message", "commit msg"), 
> 0, false, false)
>  >  +
>  >
>  >  To the end of the test suite and run "./run_lua_tests ssh_agent" it
>  >  actually FAILS in this last commit command. Perhaps the previous commits
>  >  in this test suite just succeed because Monotone is actually using the
>  >  keys on the filesystem instead the copy in the agent? At least, why does
>  >  this additional commit not succeeed?
>  >
>
>  The ssh_sgent test does plenty of commits with various options but it
>  may not run on Windows. I didn't realize that you were running on
>  Windows, it uses a different set of code to connect to Pageant. I'll
>  have to see if I can get a build working in windows (although I
>  wouldn't hold my breath).
>
>  Try removing your key from the agent and re-running your mtn ci, then
>  run a new mtn ci. The first should ask yo for your password and
>  automatically add the key to the agent and the second shouldn't
>  require a password.
>

I just looked into the mtn history and Zack did some extensive
refactoring and altering fo the ssh_agent code in rev
61a83351e0e24a39e2c413104b8a933c5768bd42. They appear to be ok but
it's a good deal of changes and I could be missing
something....especially in the win32 code as I did not write that.

-- 
Justin Patrin