monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Speedup chances


From: Jack Lloyd
Subject: Re: [Monotone-devel] Speedup chances
Date: Fri, 2 May 2008 17:33:41 -0400
User-agent: Mutt/1.5.11

On Fri, May 02, 2008 at 02:18:14PM -0700, Eric Anderson wrote:
> Jack Lloyd writes:
>  > On Fri, May 02, 2008 at 09:05:06PM +0200, Christof Petig wrote:
>  > > -----BEGIN PGP SIGNED MESSAGE-----
>  > > Hash: SHA1
>  > > 
>  > > just some notes for myself on the performance problems with OE:
>  > > 
>  > > - - hex_decode is used extensively by roster.cc: parse_marking (and
>  > > expensive)
>  > > - - get_roster_version is taking 90% of the time
>  > > - - hex_decode is taking 25% of the time
>  > > - - hex_encode is taking 15% of the time (both use malloc extensively)
>  > > 
>  > > Most probably a hand coded hex decoder for a fixed length of 40 digits
>  > > would not take 10000 cycles per call 8-O
>  > 
>  > [ want faster hex encode/decode ]
> 
> Revision acbe5243f51aa69674dc1cd8675a49835bfca8db includes a fix to
> transforms.{cc,hh} to have a fast string -> string hex encoder.  If

Apropos of nothing, but I also see from that revision

        * hmac.cc: Instantiate \"SHA-160\" not \"SHA-1\"
        (corrects lookup miss in botan's algorithm table).

I didn't find that bug until over a year later, when it started
causing crashes in a production server. :(

-Jack




reply via email to

[Prev in Thread] Current Thread [Next in Thread]