monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: nvm.stripped


From: Jack Lloyd
Subject: Re: [Monotone-devel] Re: nvm.stripped
Date: Sun, 12 Oct 2008 12:13:38 -0400
User-agent: Mutt/1.5.16 (2007-06-09)

On Sun, Oct 12, 2008 at 09:53:34AM -0600, Derek Scherger wrote:

> Heh, just noticed that too. I've merged and pushed so things are good. I
> removed -DTEMP_STORE from AM_CFLAGS in Makefile.am in the merged version. As
> near as I can tell this was only relevant for SQLITE.

Two things on nvm.stripped (rev b6c549d4c9c28227000b62a3fe26b8e9aa7d6ab1)

I am warned:

Makefile.am:339: whitespace following trailing backslash

There is a trailing tab on that line.

Also, here is the output currently when configure encounters a version
of Botan from the future:

checking for Botan... configure: WARNING: Your botan library version (1.7.18) 
is newer than expected. Monotone might not build cleanly.
yes (version 1.7.18)

By reordering the messages in botan.m4

#
# old_revision [b6c549d4c9c28227000b62a3fe26b8e9aa7d6ab1]
#
# patch "m4/botan.m4"
#  from [c3b115c9be716601db0f21612a5a6b1e4ac720ab]
#    to [e9cd9dc87a81965e626353055f6c58c86a63d947]
#
============================================================
--- m4/botan.m4 c3b115c9be716601db0f21612a5a6b1e4ac720ab
+++ m4/botan.m4 e9cd9dc87a81965e626353055f6c58c86a63d947
@@ -43,13 +43,14 @@ AC_DEFUN([MTN_FIND_BOTAN],
 #endif],
     [botan_version_match=yes],
     [botan_version_match=no])
-    if test $botan_version_match = no; then
-      AC_MSG_WARN([Your botan library version ($BOTAN_VERSION) is newer than 
expected. Monotone might not build cleanly.])
-    fi
 
     CPPFLAGS="$save_CPPFLAGS"
     AC_MSG_RESULT([yes (version $BOTAN_VERSION)])
 
+    if test $botan_version_match = no; then
+      AC_MSG_WARN([Your botan library version ($BOTAN_VERSION) is newer than 
expected. Monotone might not build cleanly.])
+    fi
+
     # AC_MSG_NOTICE([using botan compile flags: "$BOTAN_CPPFLAGS"])
     # AC_MSG_NOTICE([using botan link flags: "$BOTAN_LIBS"])


more readable output is produced:

checking for Botan... yes (version 1.7.18)
configure: WARNING: Your botan library version (1.7.18) is newer than expected. 
Monotone might not build cleanly.

-Jack




reply via email to

[Prev in Thread] Current Thread [Next in Thread]