Re: [Monotone-devel] Trouble to pull from monotone.ca and mtn-host.prjek.net

[Timothy Brownawell]

On Thu, 2009-02-19 at 00:58 +0000, Timothy Brownawell wrote:

> However, there's apparently something at the end of refinement that's
> spinning the server CPU for several minutes (only on initial pull,
> synchronizing when there are no or only a few revisions to send is still
> fast). If this takes > 10 minutes (happens sometimes when I try against
> mtn-host) the connection will drop from being idle too long.
> 
> The spinning happens at least since c47748c78... (Jan 12) and with
> current head.
> 

Fixed in 161846887551b183fc44a38d436b83c87e2d8898. Looks like this would
probably have been introduced around 2008-10-18 or so.

output_overfull() was broken, looking at the number of packets queued up
instead of the number of bytes. This made maybe_step() try to queue
*everything* as soon as refinement finished, without tending to the
event loop.



--- netsync.cc  10ad35a13e22f634408841417f955416b2ec4ec3
+++ netsync.cc  4b794f16146e3920795592e55498535f729c811d
@@ -375,7 +375,7 @@ protected:
   }
   bool output_overfull() const
   {
-    return outbuf.size() > constants::bufsz * 10;
+    return outbuf_size > constants::bufsz * 10;
   }
 public:
   string peer_id;


-- 
Timothy

Free (experimental) public monotone hosting: http://mtn-host.prjek.net