monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: [PATCH 1/2] git_export: avoid multiple sql que


From: Derek Scherger
Subject: Re: [Monotone-devel] Re: [PATCH 1/2] git_export: avoid multiple sql queries
Date: Mon, 9 Mar 2009 20:59:52 -0600

On Mon, Mar 9, 2009 at 6:37 PM, Jack Lloyd <address@hidden> wrote:

From 5 minutes to 3 seconds on my desktop. Nice!

However, a minor problem: in cases where two keys signed a revision,
log will now show the changelog and branch certs twice. This is mostly
visible on merge certs.

Yeah, I noticed this after I had committed the change as well. I don't think it's a big issue but if it is we could ensure that cert names and values are unique. I recall that someone once thought being able to list the key that signed a cert might also be useful and this would be another option but might mean that printing the duplicate certs is the right thing to do.

I haven't looked in detail but I'm not sure what was removing the duplicates in the earlier code. There's nothing obvious that was removing them that I can see.

Also (very minor, AFIACT): datestamps and author ids of certs with
multiple signers are printed in a different order than prior. I'm not
sure if anything cares about that, though.

Yes, I noticed this as well... there are a very small number in my monotone db where this is the case. If it's an issue we can sort the values to keep the order stable. I don't know what was responsible for the previous order.

Cheers,
Derek


reply via email to

[Prev in Thread] Current Thread [Next in Thread]