[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Possible Minor Bug With Automate Stdio I/F select.
From: |
Zack Weinberg |
Subject: |
Re: [Monotone-devel] Possible Minor Bug With Automate Stdio I/F select... |
Date: |
Sun, 3 May 2009 11:12:14 -0700 |
On Sun, May 3, 2009 at 5:49 AM, Anthony Edward Cooper
<address@hidden> wrote:
> default:
> - W(F("unknown selector type: %c") % sel[0]);
> + E(false, origin::user, F("unknown selector type: %c") % sel[0]);
> break;
That's a fairly significant behavior change and visible to
non-automate use, but it seems to me that it's maybe what we actually
want -- something like "mtn log --from x:" right now spews every
revision in the database to stderr...
I'd like to hear what other people think before it lands, though.
Minor style nit: since E(false, ...) unconditionally throws, remove
the 'break;' afterward.
zw