Re: [Monotone-devel] Merging branch to allow duplicate key names, have certs use key hash

[Timothy Brownawell]

On Sat, 2009-08-15 at 15:02 +0200, Thomas Keller wrote:
> Thomas Keller schrieb:
> > Thanks for your work! I'll have a deeper look at your other changes
> > tonight, currently on the run - weekend shopping :-/
> 
> I had the chance to look over it and everything seems fine now. I
> haven't tested the netsync part though, but I guess you have some tests
> in place which check the read-permissions / write-permissions part.

Well, really just all the existing netsync tests, but I did just now
change the netsync_permission test to check use of key hashes in the
permissions files.

> One last (small) thing I noticed is the usage of the term "KEYID" in the
> commands - right now four commands use it:
> 
> automate.cc
> 1784:CMD_AUTOMATE(genkey, N_("KEYID PASSPHRASE"),
> 
> cmd_key_cert.cc
> 32:CMD(genkey, "genkey", "", CMD_REF(key_and_cert), N_("KEYID"),
> 60:CMD(dropkey, "dropkey", "", CMD_REF(key_and_cert), N_("KEYID"),
> 107:CMD(passphrase, "passphrase", "", CMD_REF(key_and_cert), N_("KEYID"),
> 
> As far as I can see `dropkey` accepts either a non-unique given_name or
> a unique hash, so "KEYID" might be correct (maybe the usage term could
> explain a bit more what else is accepted beside the given_name), but for
> `(automate) genkey` only the given_name is usable, so we should probably
> rename it from KEYID to KEY_NAME there.

These should be clarified now.

> Then I found a small nuisance when changing the passphrase of a key:

> Apparently the `passphrase` command does not yet uses the new key
> identification resolver.

This should be fixed now.