[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] [bug #29576] mtn tries to rewrite options file every ti

From: Thomas Keller
Subject: [Monotone-devel] [bug #29576] mtn tries to rewrite options file every time
Date: Sat, 17 Apr 2010 07:27:11 +0000
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; de-de) AppleWebKit/531.22.7 (KHTML, like Gecko) Version/4.0.5 Safari/531.22.7

Follow-up Comment #1, bug #29576 (project monotone):

I understand where you're heading - but the problem is the underlying
"architecture" of this feature. _MTN/options is supposed to save options which
the user entered on command line to avoid that he has to enter them again -
while it makes no difference for it whether or not the triggered command has a
readonly-style or even needs the listed options in _MTN/options or whether the
usage of an option would even be considered harmful (f.e. mtn status -d
path/to/other.db ends up rewriting _MTN/options even if the other db does not
(!) contain the base revision of the workspace).

So if anybody wants to pick that up, we should discuss how we improve the
situation here. I'd propose two changes:

1) Save any given options back to _MTN/options at the very end of the
execution (f.e. in _after_ it has been clear that no exception
occurred - so we don't remember possibly harmful settings.

2) Only save those options back to _MTN/options which have actually been
given by the user on the command line - this would probably need a little
fiddling with the <someopt>_given flag we set even for options from
_MTN/options (or we leave that alone and find another way to determine which
options have been given by the user and which not). Note that there is also a
hook which returns default command options for a command.
Alternatively we could always save back the options to _MTN/options unless
another global command line option is given, f.e. --skip-options-saving or
something similar.


Reply to this item at:


  Nachricht geschickt von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]