On Sun, Apr 18, 2010 at 2:40 PM, Thomas Keller
<address@hidden> wrote:
Heh, very cool, thanks Derek! Does this code change also fix the problem
that _MTN/options is written out even if the command does not succeed?
I don't think so. This change was to the set_options function in work.cc. The places that call this explicitly do so very late so there's not much left to fail.
This function is also called by some of the workspace constructors which is probably where the trouble is... create a workspace and write out any changed options before doing something that might fail. Presumably these places should all be changed to explicitly call set_options after they've finished whatever they're doing so that failures wouldn't result in changed options.
Cheers,
Derek