monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: netsync connection info cleanup


From: Thomas Keller
Subject: Re: [Monotone-devel] Re: netsync connection info cleanup
Date: Wed, 28 Apr 2010 13:13:59 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.9) Gecko/20100317 SUSE/3.0.4-1.1.1 Lightning/1.0b2pre Thunderbird/3.0.4

Am 28.04.2010 08:50, schrieb address@hidden:
> On Wed, Apr 28, 2010 at 12:36:59PM +0200, Thomas Moschny wrote:
>> Am Sun, 18 Apr 2010 20:49:37 +0200
>> schrieb Thomas Keller <address@hidden>:
>>
>>> Secondly, I'd actively deprecate any branch name which does not match
>>> the following regular expression, i.e. by throwing a warning when a
>>> branch cert which a different value is created:
>>>
>>>    ^([\w\d]+([-][\w\d]+)*)(\.[\w\d]+([-][\w\d]+)*)*$
>>
>> Sounds good to me, but maybe we have to ask our users, whether that'd
>> be ok for them. And we should still allow them to use other branch names
>> if they wish so (because technically, there's no need for such a
>> restriction).
>>
>> "mtn ls branches | grep -v -E '^(\w+(-\w+)*)(\.\w+(-\w+)*)*$'" shows only
>> one branch that doesn't match in my local copy of the monotone db
>> (prjek.net:tester).
> 
> And what would you do with that branch if this were to become a 
> restriction?

Well, we could still handle branches like this, but we'd enforce the
usage of url encoding, i.e. if a branch name looks like this

        -foo*,bar

we would be able to handle it when it is given so:

        %2Dfoo%2Cbar%2A

And to avoid that the user would have to encode that by hand, we'd make
the "compatibility" arguments and options BRANCH_PATTERN [--exclude=...]
to convert the given value to the internal, url-escaped version.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]