Re: [Monotone-devel] bugfest analysis

[Stephen Leake]

Derek Scherger <address@hidden> writes:

> On Sun, May 9, 2010 at 5:28 PM, Thomas Keller <address@hidden> wrote:
>
>> * #13604: need 'undelete' ('undrop'?)
>>  -> net.venge.monotone.bugfest-2010.13604-stephen_leake
>>  -> patch looks largely cool, some minor objections:
>>    "revert = not undrop;" - is the "not" operator portable?
>>    "bool undrop" function argument - an enum would be cool :)
>>  -> possible issue left: undrop does not work correctly when
>>     called on a dropped directory without --recursive. It still
>>     re-creates all childs of the directory, while one would assume
>>     that only the directory itself is recreated (and all the other
>>     files keep dropped)
>>  -> points: 5 to Stephe (if the remaining issues are sorted out)
>>
>
> I'm somewhat curious about  this one but I haven't looked at the bug or the
> fixes yet. Is undrop/undelete somehow different from revert or is this just
> a command alias?

It is a minor modification of revert; I factored out the common code.

undrop just tells revert not to revert a file that is present in the
workspace, because it had changes when it was dropped.

-- 
-- Stephe