Re: [Monotone-devel] Re: netsync connection info cleanup

[Timothy Brownawell]

On 06/09/2010 10:02 PM, Timothy Brownawell wrote:
> On 06/09/2010 06:34 PM, Thomas Keller wrote:
> > We could still disallow '+' if we'd want to make inclusion also
> > explicit, but some people disagreed on this. Personally I won't mind.
>
> Well, the reason for '+' is more that a '+' in a url translates to a
> space after urldecoding. So for example 'mtn://foo.com/bar?abc+def'
> would translate to an include pattern of "abc def" and to get an include
> pattern of "abc+def" you'd need 'mtn://foo.com/bar?abc%2Bdef'. Which
> would be annoying to remember, especially if you don't typically work
> with urls.
>
> ...hm. Except that our urldecode is broken and doesn't actually do this.
> Which could be annoying for people who do work with urls regularly and
> do put spaces in their branch names for some reason.

Looking at this further (rfc 3986), '+' is a "reserved character" that 
*can* have a special meaning in a particular scheme but is not generally 
interpreted as a space or anything else special.

So nevermind then, plusses are fine and our urldecode doesn't need 
fixing (and the only confused people will be those who are somewhat 
foggy on the difference between URLs in general and http URLs in 
particular).

--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net