[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] kill_*_locally
From: |
Timothy Brownawell |
Subject: |
[Monotone-devel] kill_*_locally |
Date: |
Tue, 15 Jun 2010 07:33:26 -0500 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 |
There's a branch nvm.kill_certs_locally that adds a command
db kill_certs_locally SELECTOR CERTNAME [CERTVAL]
and updates 'mtn cert' to accept a selector that can be multiple
revisions instead of just one.
This also *removes* 'db kill_tag_locally' and
'db kill_branch_certs_locally'.
Does anyone think it's a really horrible idea to just remove those? I
suppose it would also be possible to deprecate them by marking them
hidden and making them print a warning to use kill_certs_locally instead.
If we are OK with just removing things, we could put this and
kill_rev_locally as "mtn local kill_certs" and
"mtn local kill_revision" instead of "mtn db kill_*_locally".
http://lists.nongnu.org/archive/html/monotone-devel/2010-06/msg00059.html
Also the naming is somewhat stupid - yes, they're triggered locally
(just like everything else under db), so we might as well group all of
them in a special "local" group and skip the "_locally" suffix. The
explanation of the "local" group could make it very clear that using
these commands will not change anything remotely and might even bring
back things which have been killed once. And if spelling it out is not a
problem, why do we use kill_rev_locally and not kill_revision_locally?
Ok, this is just a minor nitpick - but it teases me every time I see it.
--
Timothy
Free public monotone hosting: http://mtn-host.prjek.net
- [Monotone-devel] kill_*_locally,
Timothy Brownawell <=