Re: [Monotone-devel] monotone 0.48 released

[Stephen Leake]

Thomas Keller <address@hidden> writes:

> Am 18.06.2010 11:25, schrieb Stephen Leake:
>> Stephen Leake <address@hidden> writes:
>> 
>>> I've created a branch net.venge.monotone.monotone-0.48, with the
>>> fixes above, and the '#include sanity.hh' fix. Branched from the tagged
>>> revision, of course.
>>>
>>> That breaks two tests, on windows and linux:
>>>
>>> 150 commit_default_editor                         FAIL (line 15) 0:00
>>> 127 changelog_editor                              FAIL (line 12) 0:00
>>>
>>> I'll look at that later.
>> 
>> I've now fixed these tests.
>
> I've looked over this - just to recap, the solution for the inability of
> date parsing on Win32 is to disable the date formatting - isn't that a
> bit over the top? I mean, shouldn't we simply only disable date parsing
> and not date formatting if the latter works properly (which I assume)?

We did disable only date parsing. But that means we can't output
user-formatted dates if we later expect to parse the result.

The only place parsing of user-formatted dates is used in mtn is in the
changelog editor; the commit date is output in user format, and then
parsed on return to see if it changed. Since Win32 can't parse user
formatted dates, it is output in the default date format, which Win32
can parse.

All of the other places where the user date format is used only for
output are supported on Win32.

-- 
-- Stephe