[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Please review nvm.automate_get_roster
From: |
Markus Wanner |
Subject: |
Re: [Monotone-devel] Please review nvm.automate_get_roster |
Date: |
Tue, 05 Oct 2010 12:28:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7 |
Hi,
On 10/04/2010 02:32 PM, Thomas Keller wrote:
> Please review the above branch. The branch name has not so much in
> common with the actual implementation anymore, though:
>
> * a new file_sizes table has been added which records the size
> in bytes of individual files
Per revision of each file, that is, right? Or what files?
> * two new automate commands have been added, get_file_size returns
> a single recorded file size, get_extended_manifest_of returns
> a format similar to the current roster format, but without the
> local node ids. Additionally, the format prints out the recorded
> file size for each file node
I like the get_extended_manifest_of thing, but what's the use case for
the file size? Shouldn't that rather be part of the roster, for example?
(It's easy to see the file size as a cacheable attribute).
An extra table which adds yet another place to lookup sounds rather
wasteful to me.
What's the use case for getting file size information exclusively? I
haven't ever needed just the size, but not the real data.
Just my 2c.
Regards
Markus