nel-all
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nel] minor patch + some floating point pb


From: Vincent Caron
Subject: [Nel] minor patch + some floating point pb
Date: Fri, 26 Jul 2002 19:18:06 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530

Hello,

A little patch fixing two warning and maybe raising two issues :)

I'm also having a pb with this assert in pacs/move_container.cpp, method CMoveContainer::evalAllCollisions :

  nlassert ((d0==d1)&&(d0==d2));

I'm building NeL with vc7, and I'm experiencing some minor floating pb errors. Actually I don't really blame it, the error raise on some occasions, and show a difference in one of the vector coordinates less than 1E-312. The compile profile is already 'Improve for floating point consistency', changing to default profile triggers this assert every 2 frames !

I'm not sure why this assert is here, so I can't ask to remove it like that. Any idea on the subject welcome ...
Index: nel/src/3d/coarse_mesh_manager.h
===================================================================
RCS file: /home/cvsroot/code/nel/src/3d/coarse_mesh_manager.h,v
retrieving revision 1.12
diff -c -r1.12 coarse_mesh_manager.h
*** nel/src/3d/coarse_mesh_manager.h    26 Jun 2002 16:48:58 -0000      1.12
--- nel/src/3d/coarse_mesh_manager.h    26 Jul 2002 17:21:05 -0000
***************
*** 234,240 ****
                  */
                static uint16 getPrimitiveblockId (uint32 id)
                {
!                       return (uint16)id;
                }
  
                /**
--- 234,240 ----
                  */
                static uint16 getPrimitiveblockId (uint32 id)
                {
!                       return (uint16)(id & 0xFFFF);
                }
  
                /**
Index: nel/src/misc/bitmap.cpp
===================================================================
RCS file: /home/cvsroot/code/nel/src/misc/bitmap.cpp,v
retrieving revision 1.25
diff -c -r1.25 bitmap.cpp
*** nel/src/misc/bitmap.cpp     3 Jul 2002 13:36:25 -0000       1.25
--- nel/src/misc/bitmap.cpp     26 Jul 2002 17:21:05 -0000
***************
*** 2526,2532 ****
        sint32 nHeight = getHeight(0);
        sint32 i, j;
        NLMISC::CRGBA *pBitmap = (NLMISC::CRGBA*)&_Data[0][0];
!       bool needRebuild;
        CRGBA temp;
  
        if(_MipMapCount>1)
--- 2526,2532 ----
        sint32 nHeight = getHeight(0);
        sint32 i, j;
        NLMISC::CRGBA *pBitmap = (NLMISC::CRGBA*)&_Data[0][0];
!       bool needRebuild = false;
        CRGBA temp;
  
        if(_MipMapCount>1)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]