[Nufw-devel] Re: [PATCH 1/3] [kernel patch] fixed duration connection

[Harald Welte]

On Sat, Apr 08, 2006 at 09:56:52PM +0200, Patrick McHardy wrote:
> I don't have any principle objections against merging this (if
> there are no objections from others), a couple of comments
> on the patch though.

Well, if we merge it for ip_conntrack, we _have_ to also merge it into
nf_conntrack for consistency reasons.

> +#if defined(CONFIG_IP_NF_CT_FIXED_TIMEOUT) ||
> defined(CONFIG_NF_CT_FIXED_TIMEOUT)
> +    /* Connection has fixed timeout. */
> +     IPS_FIXED_TIMEOUT_BIT = 10,
> +     IPS_FIXED_TIMEOUT = (1 << IPS_FIXED_TIMEOUT_BIT),
> +#endif
> 
> Probably not worth adding a config option for this.

not for the bit, but in general we would need one, otherwise we have an
(extremely large) timer entry per conntrack...

-- 
- Harald Welte <address@hidden>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

pgpPaLWpr0rS2.pgp
Description: PGP signature