[Octave-bug-tracker] [bug #32158] Error of deleting a file file path which begins with '\' on MinGW

[Tatsuro MATSUOKA]

Follow-up Comment #6, bug #32158 (project octave):

>P_tmpdir is still empty after applying the patch?
 Before applying your patch P_tmpdir is '' (backslash) but not empty. The
unlink on mingw fails to delte '(path name of file)
This causes fails to delete temporary file like octave-help-xxxxx.

Ooops!  I remember!

http://octave.1599824.n4.nabble.com/quot-Error-unlink-is-not-a-member-of-gnulib-quot-on-the-recent-check-out-of-development-branch-was-R-td2252605.html#a2253063

http://octave.1599824.n4.nabble.com/compile-error-on-oct-env-cc-in-building-octave-3-3-52-on-MinGW32-td2549610.html#a2549977

So I am using local patch.

The below is my local patch
*******************************
--- a/src/oct-hist.cc   2010-03-16 17:25:40.703125000 +0900
+++ b/src/oct-hist.cc   2010-07-28 12:02:50.798004100 +0900
@@ -423,7 +423,7 @@
 static void
 unlink_cleanup (const char *file)
 {
-  gnulib::unlink (file);
+  unlink (file); //gnulib::unlink (file);
 }

 static void
*********************************
--- octave/liboctave/oct-env.cc 2010-11-12 07:31:06 +0900
+++ octave-work/liboctave/oct-env.cc    2010-11-22 12:03:04 +0900
@@ -447,7 +447,7 @@
     {
       char hostname[1024];
 
-      int status = gnulib::gethostname (hostname, 1023);
+      int status = gethostname (hostname, 1023); //gnulib::gethostname
(hostname, 1023);
 
       host_name = (status < 0) ? "unknown" : hostname;
     }
**********************************

I do not test the current gnulib solve the above issues.

Is it better to test, the below are fixed using current gnulib source?  If
the bug will not be fixed, is it better register this issue to the bug
tracker?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32158>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/