[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #32683] incorrect ndarray concatenation
From: |
Jordi Gutiérrez Hermoso |
Subject: |
[Octave-bug-tracker] [bug #32683] incorrect ndarray concatenation |
Date: |
Tue, 26 Jul 2011 07:34:55 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20110109 Firefly/3.6.13 |
Update of bug #32683 (project octave):
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #5:
Fixed in this changeset:
http://hg.savannah.gnu.org/hgweb/octave/rev/73e75ff9c31b
Boring diagnosis: the codepath for vertically concatenating two things with 2d
matrix vertical concatenation syntax (e.g. [x;y]) eventually lands there, and
as you can see in the cset above, it has checks to see if you're concatenating
things of higher dimensionaliity than matrices. If it does, it keeps the
indices for matrices and sets the higher dimensional indices to 0 and then
assigns the appropriate locations for everything else. Unfortunately, the bug
was discarding the 2d indices and setting them to zero as well, so everything
was always getting written to the top of the output array instead of the
bottom where the concatenated stuff should have been. The output matrix had
already been previously sized to the right dimensions but its contents weren't
initialised, which led to the uninitialised memory seen before.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?32683>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/