octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #36372] Improved ranks.m included:


From: Jordi Gutiérrez Hermoso
Subject: [Octave-bug-tracker] [bug #36372] Improved ranks.m included:
Date: Wed, 02 May 2012 18:08:14 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20110109 Turbocat/3.6.13

Follow-up Comment #2, bug #36372 (project octave):

Oops, I meant to refer you to this part of the Octave manual:

http://www.gnu.org/software/octave/doc/interpreter/Basics-of-Generating-a-Changeset.html

Also, some instructions on how to write the commit message:

http://www.octave.org/wiki/index.php?title=Commit_message_guidelines

In your case, I would greatly appreciate if you could explain a little in your
commit message about what changed. Also, you may remove the part of the patch
that says "this may not become a part of GNU Octave" and associated text. Part
of that text should become a unit test (look at the bottom of the file for the
syntax for writing tests).

Your comments about the code being ugly are fine, although I have a distaste
for multiple exclamation marsk!!!

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36372>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]