[Octave-bug-tracker] [bug #51767] Convenience function ovl() may be causing compilation error

[Dan Sebald]

Follow-up Comment #4, bug #51767 (project octave):

The patch compiles past the file-io.cc errors.  However, there is another:


  CXX      libgui/graphics/libgui_graphics_libgui_graphics_la-Canvas.lo
In file included from
/home/sebald/octave/octave/octave/libinterp/octave-value/ov-fcn.h:33:0,
                 from
/home/sebald/octave/octave/octave/libinterp/octave-value/ov-builtin.h:32,
                 from
/home/sebald/octave/octave/octave/libinterp/corefcn/defun-int.h:30,
                 from
/home/sebald/octave/octave/octave/libinterp/corefcn/defun-dld.h:32,
                 from
/home/sebald/octave/octave/octave/libinterp/dldfcn/dmperm.cc:33:
/home/sebald/octave/octave/octave/libinterp/octave-value/ovl.h: In
instantiation of 'octave_value_list ovl(const OV_Args& ...) [with OV_Args =
{octave_value_list}]':
/home/sebald/octave/octave/octave/libinterp/dldfcn/dmperm.cc:146:56:  
required from here
/home/sebald/octave/octave/octave/libinterp/octave-value/ovl.h:192:76: error:
converting to 'octave_value' from initializer list would use explicit
constructor 'octave_value::octave_value(const octave_value_list&)'
   return octave_value_list (std::initializer_list<octave_value>
({args...}));
                                                                            ^
make[2]: *** [libinterp/dldfcn/libinterp_dldfcn_dmperm_la-dmperm.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/usr/local/src/octave/octave/build5'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/src/octave/octave/build5'
make: *** [all] Error 2


I did the same thing as in the attached patch with the dmperm.cc file, i.e.,


diff --git a/libinterp/corefcn/file-io.cc b/libinterp/corefcn/file-io.cc
--- a/libinterp/corefcn/file-io.cc
+++ b/libinterp/corefcn/file-io.cc
@@ -1000,7 +1000,7 @@ scanf_internal (octave::interpreter& int
 
   if (nargin == 3 && args(2).is_string ())
     {
-      retval = ovl (os.oscanf (args(1), who));
+      retval = os.oscanf (args(1), who);
     }
   else
     {
@@ -1123,7 +1123,7 @@ character to be read is returned in @var
 
   if (nargin == 3 && args(2).is_string ())
     {
-      retval = ovl (os.oscanf (args(1), who));
+      retval = os.oscanf (args(1), who);
     }
   else
     {
diff --git a/libinterp/dldfcn/dmperm.cc b/libinterp/dldfcn/dmperm.cc
--- a/libinterp/dldfcn/dmperm.cc
+++ b/libinterp/dldfcn/dmperm.cc
@@ -143,7 +143,7 @@ ACM Trans. Math. Software, 16(4):303-324
   if (args.length () != 1)
     print_usage ();
 
-  return ovl (dmperm_internal (false, args(0), nargout));
+  return dmperm_internal (false, args(0), nargout);
 
 #else
 
@@ -191,7 +191,7 @@ such the numerical rank of the matrix @v
   if (args.length () != 1)
     print_usage ();
 
-  return ovl (dmperm_internal (true, args(0), nargout));
+  return dmperm_internal (true, args(0), nargout);
 
 #else
 


and compilation makes it all the way through...wuup, not quite--looks like it
is stuck on


  GEN      doc/interpreter/octave.html/octave.css
  TEXI2PDF doc/interpreter/octave.pdf


of all things, no CPU being used or anything.

Anyway, I didn't look to closely what the return value means in the particular
cases and will leave that up to you.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51767>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/