octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #51203] [octave-forge] (io) xlsopen/xlsclose m


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #51203] [octave-forge] (io) xlsopen/xlsclose may create spurious files/folders instead of .xlsx file with "OCT" interface
Date: Mon, 11 Sep 2017 13:09:06 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Follow-up Comment #77, bug #51203 (project octave):

Hi Philip,

No worries. Whenever you have time.

Below some comments to your questions:


__OCT_spsh_close__.m

    Where is variable adddToFile (L.23) used?


I forgot to delete this line, which was only useful during debugging.


    What is the use of hunk L.30-35?


If I recall correctly, InfoZip messed with relative paths if the zip-file that
it creates was NOT located in the same directory as the source files. Those
lines move the zipped file created in the temp directory (line 27) to the
destination directory and rename it from .zip to .xlsx.


__OCT_spsh_open__.m
-------------------

    What is the use of variable i_open in L.76? It is nowhere used


Debug variable I forgot to delete for the final patch. The same with t_unpack
in line 60. Sorry.


    Why do you want:

- fid = fopen (sprintf ('%s/xl/workbook.xml', tmpdir));

to be changed by

+ workbook_xml = sprintf ('%s/xl/workbook.xml', tmpdir);
+ fid = fopen (workbook_xml);


Same as above. Please ignore.

Looking further below in the patch (lines 92-97), it looks like I might have
messed up the indentation (not sure if I read the patch correctly). You might
want to ignore that hunk as well...

Sorry for the messy patch. I shouldn't try and hurry...
When I have some minutes, I'll clean the patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51203>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]