|
| From: | Mike Miller |
| Subject: | [Octave-bug-tracker] [bug #49053] figure scaling issue with Qt 5 on macOS with Retina / HiDPI scaling |
| Date: | Fri, 19 Jan 2018 18:50:07 -0500 (EST) |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 |
Follow-up Comment #70, bug #49053 (project octave):
Ben - a couple fixes to your latest combined patch:
* the commit log lines should also be wrapped to 80 columns
* in the commit log, you can use "acinclude.m4
(OCTAVE_CHECK_FUNC_QSCREEN_DEVICEPIXELRATIO): New macro." at a minimum, or
"New macro to test ..." if you want to add a description
* the indent at the #if conditional block is still wrong
Other than that, and the outstanding FLTK issues, looks ok to me.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?49053>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |